Re: [PATCH] crypto: geode-aes - switch to skcipher for cbc(aes) fallback

2019-10-04 Thread Gert Robben
Op 04-10-2019 om 21:37 schreef Eric Biggers: On Fri, Oct 04, 2019 at 03:29:33PM +0200, Gert Robben wrote: Op 04-10-2019 om 08:16 schreef Ard Biesheuvel: On Thu, 3 Oct 2019 at 23:26, Gert Robben wrote: Op 03-10-2019 om 15:39 schreef Ard Biesheuvel: Commit 79c65d179a40e145 ("crypto: cbc - Conv

Re: [PATCH] crypto: geode-aes - switch to skcipher for cbc(aes) fallback

2019-10-04 Thread Eric Biggers
On Fri, Oct 04, 2019 at 03:29:33PM +0200, Gert Robben wrote: > Op 04-10-2019 om 08:16 schreef Ard Biesheuvel: > > On Thu, 3 Oct 2019 at 23:26, Gert Robben wrote: > > > Op 03-10-2019 om 15:39 schreef Ard Biesheuvel: > > > > Commit 79c65d179a40e145 ("crypto: cbc - Convert to skcipher") updated > > >

Re: [PATCH] crypto: geode-aes - switch to skcipher for cbc(aes) fallback

2019-10-04 Thread Gert Robben
Op 04-10-2019 om 08:16 schreef Ard Biesheuvel: On Thu, 3 Oct 2019 at 23:26, Gert Robben wrote: Op 03-10-2019 om 15:39 schreef Ard Biesheuvel: Commit 79c65d179a40e145 ("crypto: cbc - Convert to skcipher") updated the generic CBC template wrapper from a blkcipher to a skcipher algo, to get away

Re: [PATCH] crypto: geode-aes - switch to skcipher for cbc(aes) fallback

2019-10-04 Thread Ard Biesheuvel
On Fri, 4 Oct 2019 at 12:21, Florian Bezdeka wrote: > > I'm facing the same problem on one of my VPN gateways. > > I updated the affected system from Debian Stretch to Buster. > Therefore the kernel was updated from 4.9.x to 4.19.x > > The supplied patch uses some symbols / functions that were int

Re: [PATCH] crypto: geode-aes - switch to skcipher for cbc(aes) fallback

2019-10-04 Thread Florian Bezdeka
I'm facing the same problem on one of my VPN gateways. I updated the affected system from Debian Stretch to Buster. Therefore the kernel was updated from 4.9.x to 4.19.x The supplied patch uses some symbols / functions that were introduced with 4.19 (like crypto_sync_skcipher_clear_flags()) so s

Re: [PATCH] crypto: geode-aes - switch to skcipher for cbc(aes) fallback

2019-10-03 Thread Ard Biesheuvel
On Thu, 3 Oct 2019 at 23:26, Gert Robben wrote: > > Op 03-10-2019 om 15:39 schreef Ard Biesheuvel: > > Commit 79c65d179a40e145 ("crypto: cbc - Convert to skcipher") updated > > the generic CBC template wrapper from a blkcipher to a skcipher algo, > > to get away from the deprecated blkcipher inter

Re: [PATCH] crypto: geode-aes - switch to skcipher for cbc(aes) fallback

2019-10-03 Thread Gert Robben
Op 03-10-2019 om 15:39 schreef Ard Biesheuvel: Commit 79c65d179a40e145 ("crypto: cbc - Convert to skcipher") updated the generic CBC template wrapper from a blkcipher to a skcipher algo, to get away from the deprecated blkcipher interface. However, as a side effect, drivers that instantiate CBC t