Re: [PATCH] crypto: aegis128 - deal with missing simd.h header on some architecures

2019-07-29 Thread Herbert Xu
On Mon, Jul 29, 2019 at 12:32:33PM +0300, Ard Biesheuvel wrote: > > This seems to work Looks good to me. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: aegis128 - deal with missing simd.h header on some architecures

2019-07-29 Thread Ard Biesheuvel
On Mon, 29 Jul 2019 at 12:21, Herbert Xu wrote: > > On Mon, Jul 29, 2019 at 12:15:20PM +0300, Ard Biesheuvel wrote: > > > > It is simply a matter of adding simd.h to the various > > arch/<...>/include/asm/Kbuild files, but we'd have to do that for all > > architectures. > > How does errno.h get ad

Re: [PATCH] crypto: aegis128 - deal with missing simd.h header on some architecures

2019-07-29 Thread Herbert Xu
On Mon, Jul 29, 2019 at 12:15:20PM +0300, Ard Biesheuvel wrote: > > It is simply a matter of adding simd.h to the various > arch/<...>/include/asm/Kbuild files, but we'd have to do that for all > architectures. How does errno.h get added then? It doesn't appear to be in the m68k (or arm) Kbuild fi

Re: [PATCH] crypto: aegis128 - deal with missing simd.h header on some architecures

2019-07-29 Thread Ard Biesheuvel
On Mon, 29 Jul 2019 at 12:12, Herbert Xu wrote: > > Ard Biesheuvel wrote: > > The generic aegis128 driver has been updated to support using SIMD > > intrinsics to implement the core AES based transform, and this has > > been wired up for ARM and arm64, which both provide a simd.h header. > > > >

Re: [PATCH] crypto: aegis128 - deal with missing simd.h header on some architecures

2019-07-29 Thread Herbert Xu
Ard Biesheuvel wrote: > The generic aegis128 driver has been updated to support using SIMD > intrinsics to implement the core AES based transform, and this has > been wired up for ARM and arm64, which both provide a simd.h header. > > As it turns out, most architectures don't provide this header,

Re: [PATCH] crypto: aegis128 - deal with missing simd.h header on some architecures

2019-07-29 Thread Geert Uytterhoeven
Hi Ard, On Mon, Jul 29, 2019 at 10:02 AM Ard Biesheuvel wrote: > On Mon, 29 Jul 2019 at 10:55, Geert Uytterhoeven wrote: > > On Mon, Jul 29, 2019 at 9:44 AM Ard Biesheuvel > > wrote: > > > The generic aegis128 driver has been updated to support using SIMD > > > intrinsics to implement the core

Re: [PATCH] crypto: aegis128 - deal with missing simd.h header on some architecures

2019-07-29 Thread Ard Biesheuvel
On Mon, 29 Jul 2019 at 10:55, Geert Uytterhoeven wrote: > > Hi Ard, > > On Mon, Jul 29, 2019 at 9:44 AM Ard Biesheuvel > wrote: > > The generic aegis128 driver has been updated to support using SIMD > > intrinsics to implement the core AES based transform, and this has > > been wired up for ARM a

Re: [PATCH] crypto: aegis128 - deal with missing simd.h header on some architecures

2019-07-29 Thread Geert Uytterhoeven
Hi Ard, On Mon, Jul 29, 2019 at 9:44 AM Ard Biesheuvel wrote: > The generic aegis128 driver has been updated to support using SIMD > intrinsics to implement the core AES based transform, and this has > been wired up for ARM and arm64, which both provide a simd.h header. > > As it turns out, most