Re: [PATCH] MPI: Fix mpi_read_buffer

2015-09-15 Thread Tadeusz Struk
On 09/15/2015 05:24 AM, Herbert Xu wrote: >>> Change mpi_read_buffer to return a number without leading zeros >>> > > so that mpi_read_buffer and mpi_get_buffer return the same thing. >> > >> > Hmmm... This would appear to have the undesirable side effect of causing 1 >> > out of 256 module signi

Re: [PATCH] MPI: Fix mpi_read_buffer

2015-09-15 Thread Herbert Xu
On Tue, Sep 15, 2015 at 10:09:56AM +0100, David Howells wrote: > Tadeusz Struk wrote: > > > Change mpi_read_buffer to return a number without leading zeros > > so that mpi_read_buffer and mpi_get_buffer return the same thing. > > Hmmm... This would appear to have the undesirable side effect of

Re: [PATCH] MPI: Fix mpi_read_buffer

2015-09-15 Thread David Howells
David Howells wrote: > > Change mpi_read_buffer to return a number without leading zeros > > so that mpi_read_buffer and mpi_get_buffer return the same thing. > > Hmmm... This would appear to have the undesirable side effect of causing 1 > out of 256 module signing keys to be unusable (ie. thos

Re: [PATCH] MPI: Fix mpi_read_buffer

2015-09-15 Thread David Howells
Tadeusz Struk wrote: > Change mpi_read_buffer to return a number without leading zeros > so that mpi_read_buffer and mpi_get_buffer return the same thing. Hmmm... This would appear to have the undesirable side effect of causing 1 out of 256 module signing keys to be unusable (ie. those that beg

Re: [PATCH] MPI: Fix mpi_read_buffer

2015-08-25 Thread Herbert Xu
On Mon, Aug 24, 2015 at 07:52:14AM -0700, Tadeusz Struk wrote: > Change mpi_read_buffer to return a number without leading zeros > so that mpi_read_buffer and mpi_get_buffer return the same thing. > > Signed-off-by: Tadeusz Struk Applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org