Re: [PATCH v5 1/3] crypto: Key-agreement Protocol Primitives API (KPP)

2016-06-13 Thread Herbert Xu
On Wed, Jun 08, 2016 at 12:45:47PM +0100, Salvatore Benedetto wrote: > > Having said that, are you OK with as far as the interface goes > to only merge set_param and set_key, and keeping the rest as it is? > For the implementation of DH and ECDH I'll merge the two operations > functions into one as

Re: [PATCH v5 1/3] crypto: Key-agreement Protocol Primitives API (KPP)

2016-06-08 Thread Salvatore Benedetto
On Wed, Jun 08, 2016 at 10:54:51AM +0800, Herbert Xu wrote: > On Thu, Jun 02, 2016 at 12:06:48PM +, Benedetto, Salvatore wrote: > > > > Off the top of my head, with ECDH when the user gets a EGAIN, he wants > > to reset the secret key only, not the params. > > I don't see any performance benef

Re: [PATCH v5 1/3] crypto: Key-agreement Protocol Primitives API (KPP)

2016-06-07 Thread Herbert Xu
On Thu, Jun 02, 2016 at 12:06:48PM +, Benedetto, Salvatore wrote: > > Off the top of my head, with ECDH when the user gets a EGAIN, he wants > to reset the secret key only, not the params. I don't see any performance benefit in changing one and not the other. Besides, you could always check t

RE: [PATCH v5 1/3] crypto: Key-agreement Protocol Primitives API (KPP)

2016-06-02 Thread Benedetto, Salvatore
to@vger.kernel.org > Subject: Re: [PATCH v5 1/3] crypto: Key-agreement Protocol Primitives API > (KPP) > > On Mon, May 09, 2016 at 10:40:39PM +0100, Salvatore Benedetto wrote: > > Add key-agreement protocol primitives (kpp) API which allows to > > implement primitives required by pro

Re: [PATCH v5 1/3] crypto: Key-agreement Protocol Primitives API (KPP)

2016-05-30 Thread Herbert Xu
On Mon, May 09, 2016 at 10:40:39PM +0100, Salvatore Benedetto wrote: > Add key-agreement protocol primitives (kpp) API which allows to > implement primitives required by protocols such as DH and ECDH. > The API is composed mainly by the following functions > * set_params() - It allows the user to