RE: [PATCH v4] mm/zswap: move to use crypto_acomp API for hardware acceleration

2020-07-09 Thread Song Bao Hua (Barry Song)
.@gondor.apana.org.au; > da...@davemloft.net; linux-crypto@vger.kernel.org; linux...@kvack.org; > linux-ker...@vger.kernel.org; Linuxarm ; Luis Claudio > R . Goncalves ; Mahipal Challa > ; Seth Jennings ; > Dan Streetman ; Vitaly Wool > ; Wangzhou (B) ; > Colin Ian King >

RE: [PATCH v4] mm/zswap: move to use crypto_acomp API for hardware acceleration

2020-07-09 Thread Song Bao Hua (Barry Song)
; da...@davemloft.net; linux-crypto@vger.kernel.org; linux...@kvack.org; > linux-ker...@vger.kernel.org; Linuxarm ; Luis Claudio > R . Goncalves ; Mahipal Challa > ; Seth Jennings ; > Dan Streetman ; Vitaly Wool > ; Wangzhou (B) ; > Colin Ian King > Subject: Re: [PATCH v4]

Re: [PATCH v4] mm/zswap: move to use crypto_acomp API for hardware acceleration

2020-07-09 Thread Sebastian Andrzej Siewior
On 2020-07-09 07:55:22 [+], Song Bao Hua (Barry Song) wrote: > Hello Sebastian, thanks for your reply and careful review. Hi, > I don't think we can simply "forward the result to the caller and let him > decide". > Would you like to present some pseudo code? I provided just some pseudo code

RE: [PATCH v4] mm/zswap: move to use crypto_acomp API for hardware acceleration

2020-07-09 Thread Song Bao Hua (Barry Song)
.@gondor.apana.org.au; > da...@davemloft.net; linux-crypto@vger.kernel.org; linux...@kvack.org; > linux-ker...@vger.kernel.org; Linuxarm ; Luis Claudio > R . Goncalves ; Mahipal Challa > ; Seth Jennings ; > Dan Streetman ; Vitaly Wool > ; Wangzhou (B) ; > Colin Ian King >

Re: [PATCH v4] mm/zswap: move to use crypto_acomp API for hardware acceleration

2020-07-09 Thread Sebastian Andrzej Siewior
On 2020-07-09 01:32:38 [+], Song Bao Hua (Barry Song) wrote: > > This looks using the same synchronous mechanism around an asynchronous > > interface. It works as a PoC. > > > > As far as I remember the crypto async interface, the incoming skbs were fed > > to > > the async interface and retu

Re: [PATCH v4] mm/zswap: move to use crypto_acomp API for hardware acceleration

2020-07-09 Thread Sebastian Andrzej Siewior
On 2020-07-08 21:45:47 [+], Song Bao Hua (Barry Song) wrote: > > On 2020-07-08 00:52:10 [+1200], Barry Song wrote: > > > @@ -127,9 +129,17 @@ > > > +struct crypto_acomp_ctx { > > > + struct crypto_acomp *acomp; > > > + struct acomp_req *req; > > > + struct crypto_wait wait; > > > + u8 *dstmem;

RE: [PATCH v4] mm/zswap: move to use crypto_acomp API for hardware acceleration

2020-07-08 Thread Song Bao Hua (Barry Song)
.@gondor.apana.org.au; > da...@davemloft.net; linux-crypto@vger.kernel.org; linux...@kvack.org; > linux-ker...@vger.kernel.org; Linuxarm ; Luis Claudio > R . Goncalves ; Mahipal Challa > ; Seth Jennings ; > Dan Streetman ; Vitaly Wool > ; Wangzhou (B) ; > Colin Ian King >

RE: [PATCH v4] mm/zswap: move to use crypto_acomp API for hardware acceleration

2020-07-08 Thread Song Bao Hua (Barry Song)
.@gondor.apana.org.au; > da...@davemloft.net; linux-crypto@vger.kernel.org; linux...@kvack.org; > linux-ker...@vger.kernel.org; Linuxarm ; Luis Claudio > R . Goncalves ; Mahipal Challa > ; Seth Jennings ; > Dan Streetman ; Vitaly Wool > ; Wangzhou (B) ; > Colin Ian King >

Re: [PATCH v4] mm/zswap: move to use crypto_acomp API for hardware acceleration

2020-07-08 Thread Sebastian Andrzej Siewior
On 2020-07-08 00:52:10 [+1200], Barry Song wrote: … > @@ -127,9 +129,17 @@ module_param_named(same_filled_pages_enabled, > zswap_same_filled_pages_enabled, > * data structures > **/ > > +struct crypto_acomp_ctx { > + struct crypto_acomp *acomp; > + struc