Re: [PATCH 1/1 v8] Add CryptoAPI User Interface Support v8

2009-02-24 Thread Herbert Xu
On Mon, Feb 23, 2009 at 10:46:43AM -0800, Loc Ho wrote: > > I'd like to see a name field. It's better to have user-space > pass through a string for the type instead of an ID. > > The reason you want user-space to pass that through is so that > you can locate the crypto_type object and then call

RE: [PATCH 1/1 v8] Add CryptoAPI User Interface Support v8

2009-02-23 Thread Loc Ho
Hi, See inline... -Loc > > struct crypto_type { > unsigned int (*ctxsize)(struct crypto_alg *alg, u32 type, u32 mask); > int (*init)(struct crypto_tfm *tfm, u32 type, u32 mask); > void (*exit)(struct crypto_tfm *tfm); > void (*show)(struct seq_file *m, struct crypto_alg

Re: [PATCH 1/1 v8] Add CryptoAPI User Interface Support v8

2009-02-23 Thread Herbert Xu
On Mon, Feb 23, 2009 at 05:35:58PM +0800, Herbert Xu wrote: > > 4. Operate. > > sendmsg(fd, msg, flags); > > Here struct msghdr provides for both the IOV array and space for > ancillary information. In fact we should take this one step further. Instead of having write/send do both input a

Re: [PATCH 1/1 v8] Add CryptoAPI User Interface Support v8

2009-02-23 Thread Herbert Xu
On Fri, Feb 06, 2009 at 04:13:40PM -0800, Loc Ho wrote: > > struct crypto_type { > unsigned int (*ctxsize)(struct crypto_alg *alg, u32 type, u32 mask); > int (*init)(struct crypto_tfm *tfm, u32 type, u32 mask); > void (*exit)(struct crypto_tfm *tfm); > void (*show)(struct s

RE: [PATCH 1/1 v8] Add CryptoAPI User Interface Support v8

2009-02-06 Thread Loc Ho
l still be handled by CryptoDev driver. This avoids creating a bunch of complication for each type of CryptoAPI type of algorithms. -Loc -Original Message- From: Herbert Xu [mailto:herb...@gondor.apana.org.au] Sent: Tuesday, January 27, 2009 8:47 PM To: Shasi Pulijala Cc: Loc Ho Subject: R

Re: [PATCH 1/1 v8] Add CryptoAPI User Interface Support v8

2009-01-12 Thread Herbert Xu
On Mon, Nov 17, 2008 at 03:31:42PM -0800, Shasi Pulijala wrote: > > This patch v8 includes the code that prevents synchronous calls from freeing > data when request completion is interrupted, while the data may still be > accessed by the crypto code in parallel. > From: Shasi Pulijala > > > S

Re: [PATCH 1/1 v8] Add CryptoAPI User Interface Support v8

2008-11-21 Thread Evgeniy Polyakov
Hi. On Mon, Nov 17, 2008 at 03:31:42PM -0800, Shasi Pulijala ([EMAIL PROTECTED]) wrote: > This patch v8 includes the code that prevents synchronous calls from freeing > data when request completion is interrupted, while the data may still be > accessed by the crypto code in parallel. > From: Sh