Re: Moving xor_* functions into common header file

2007-11-20 Thread Herbert Xu
On Tue, Nov 20, 2007 at 03:33:35PM +0800, Herbert Xu wrote: > > I'm currently working on a patch to just restrict the block > size for non-stream ciphers to multiples of 8 since that's what > we have anyway. That allows us to just use bitmap_xor. Nevermind, obviously stream ciphers do need xors t

Re: Moving xor_* functions into common header file

2007-11-19 Thread Herbert Xu
On Tue, Nov 20, 2007 at 02:34:48AM +0800, Tan Swee Heng wrote: > Hi, > > 'grep "static void xor_" crypto/*' shows that cbc.c, ctr.c, pcbc.c and > xcbc.c share similar xor_* functions. It seems a good idea to > encourage code reuse by putting them into a common header (iirc > Evgeniy suggested it

Moving xor_* functions into common header file

2007-11-19 Thread Tan Swee Heng
Hi, 'grep "static void xor_" crypto/*' shows that cbc.c, ctr.c, pcbc.c and xcbc.c share similar xor_* functions. It seems a good idea to encourage code reuse by putting them into a common header (iirc Evgeniy suggested it when reviewing one of my earlier mail). It will also be useful to me when p