Re: HMAC broken on s390

2007-12-04 Thread Herbert Xu
On Tue, Dec 04, 2007 at 09:25:11AM +0100, Jens Axboe wrote: > > You should continue to do your own chaining if it's a requirement for > the driver/layer to function, until we get rid of ARCH_HAS_SG_CHAIN. > That'll happen when all archs are converted. Thanks for the confirmation. I'll back out m

Re: HMAC broken on s390

2007-12-04 Thread Jens Axboe
On Tue, Dec 04 2007, Herbert Xu wrote: > On Mon, Dec 03, 2007 at 02:31:40PM +0100, Jan Glauber wrote: > > Hi Herbert, > > > > commit 788fefa33b0b50581585925c53c230a36af35d0e in cryptodev breaks hmac > > on s390 du to the usage of sg_chain(): > > > > static inline void sg_chain(struct scatterlist

Re: HMAC broken on s390

2007-12-03 Thread Herbert Xu
On Mon, Dec 03, 2007 at 02:31:40PM +0100, Jan Glauber wrote: > Hi Herbert, > > commit 788fefa33b0b50581585925c53c230a36af35d0e in cryptodev breaks hmac > on s390 du to the usage of sg_chain(): > > static inline void sg_chain(struct scatterlist *prv, unsigned int prv_nents, >

HMAC broken on s390

2007-12-03 Thread Jan Glauber
Hi Herbert, commit 788fefa33b0b50581585925c53c230a36af35d0e in cryptodev breaks hmac on s390 du to the usage of sg_chain(): static inline void sg_chain(struct scatterlist *prv, unsigned int prv_nents, struct scatterlist *sgl) { #ifndef ARCH_HAS_SG_CHAIN BUG();