Re: Crypto API AEAD question

2019-04-22 Thread Herbert Xu
On Mon, Apr 22, 2019 at 11:29:55AM +, Pascal Van Leeuwen wrote: > > Even so, for the in-place case, checking the AAD data would ensure the crypto > implementation didn't *accidentally* corrupt it ... Yes we probably should check it just in case some driver does something weird with it. Cheers

Crypto API AEAD question

2019-04-22 Thread Pascal Van Leeuwen
Hi, While debugging some AEAD issues with the inside-secure driver, I couldn't help but notice that the testmgr is NOT checking the AAD data section of the result. And when I added that check myself, I saw a lot of implementations failing on out-of-place vectors, with the poison data still present