Re: Converting mac80211 CCMP to packet-at-a-time processing

2010-03-18 Thread Herbert Xu
Pavel Roskin wrote: > >> You won't have to deal with completions if you allocate your >> algorithm with the CRYPTO_ALG_ASYNC bit off. Of course you won't >> be able to use most hardware accelerations either. > > Actually, I thought using CRYPTO_ALG_ASYNC in the mask meant to > _exclude_ asynchro

Re: Converting mac80211 CCMP to packet-at-a-time processing

2010-03-15 Thread Pavel Roskin
On Sat, 2010-03-13 at 20:28 +0800, Herbert Xu wrote: > Pavel Roskin wrote: > > > > However, it's disappointing that the caller needs to deal explicitly > > with completions. The blkcipher API is much simpler. I would have hard > > time advocating a patch to CCMP that makes the code more complic

Re: Converting mac80211 CCMP to packet-at-a-time processing

2010-03-13 Thread Herbert Xu
Pavel Roskin wrote: > > However, it's disappointing that the caller needs to deal explicitly > with completions. The blkcipher API is much simpler. I would have hard > time advocating a patch to CCMP that makes the code more complicated. You won't have to deal with completions if you allocate

Re: Converting mac80211 CCMP to packet-at-a-time processing

2010-03-12 Thread Pavel Roskin
On Fri, 2010-03-12 at 11:49 +0100, Roberto Sassu wrote: > Hello > > i'm not expert with cryptographic modules, but i played sometime with the > "authenc" module, which is AEAD, and i applied it to the filesystem > "ecryptfs". > In the forwarded message i added a brief description of what i do an

Re: Converting mac80211 CCMP to packet-at-a-time processing

2010-03-12 Thread Roberto Sassu
Hello i'm not expert with cryptographic modules, but i played sometime with the "authenc" module, which is AEAD, and i applied it to the filesystem "ecryptfs". In the forwarded message i added a brief description of what i do and i hope this can be a useful example for you. --- Begin Message --

Converting mac80211 CCMP to packet-at-a-time processing

2010-03-11 Thread Pavel Roskin
Hello! The CCMP encryption in mac80211 uses crypto API to encrypt 16 bytes at a time. I believe this is not the best approach if hardware acceleration is used. The ixp4xx_crypto driver doesn't even provide the "aes" ciphers. It only provides block ciphers, such as "cbc(des)". It would be much