Re: ARM CE: CTS IV handling

2020-05-19 Thread Stephan Mueller
Am Dienstag, 19. Mai 2020, 19:53:57 CEST schrieb Ard Biesheuvel: Hi Ard, > On Tue, 19 May 2020 at 19:50, Ard Biesheuvel wrote: > > On Tue, 19 May 2020 at 19:35, Stephan Mueller wrote: > > > Am Dienstag, 19. Mai 2020, 18:21:01 CEST schrieb Ard Biesheuvel: > > > > > > Hi Ard, > > > > > > > To b

Re: ARM CE: CTS IV handling

2020-05-19 Thread Ard Biesheuvel
On Tue, 19 May 2020 at 19:50, Ard Biesheuvel wrote: > > On Tue, 19 May 2020 at 19:35, Stephan Mueller wrote: > > > > Am Dienstag, 19. Mai 2020, 18:21:01 CEST schrieb Ard Biesheuvel: > > > > Hi Ard, > > > > > > > > To be honest, this looks like the API is being used incorrectly. Is > > > this a si

Re: ARM CE: CTS IV handling

2020-05-19 Thread Ard Biesheuvel
On Tue, 19 May 2020 at 19:35, Stephan Mueller wrote: > > Am Dienstag, 19. Mai 2020, 18:21:01 CEST schrieb Ard Biesheuvel: > > Hi Ard, > > > > > To be honest, this looks like the API is being used incorrectly. Is > > this a similar issue to the one Herbert spotted recently with the CTR > > code? >

Re: ARM CE: CTS IV handling

2020-05-19 Thread Stephan Mueller
Am Dienstag, 19. Mai 2020, 18:21:01 CEST schrieb Ard Biesheuvel: Hi Ard, > > To be honest, this looks like the API is being used incorrectly. Is > this a similar issue to the one Herbert spotted recently with the CTR > code? > > When you say 'leaving the TFM untouched' do you mean the skcipher

Re: ARM CE: CTS IV handling

2020-05-19 Thread Ard Biesheuvel
(+ Eric) Hi Stephan, On Tue, 19 May 2020 at 17:31, Stephan Mueller wrote: > > Hi Ard, > > The following report applies to kernel 5.3 as I am currently unable to test > the latest upstream version. > > The CTS IV handling for cts-cbc-aes-ce and cts-cbc-aes-neon is not consistent > with the C impl

ARM CE: CTS IV handling

2020-05-19 Thread Stephan Mueller
Hi Ard, The following report applies to kernel 5.3 as I am currently unable to test the latest upstream version. The CTS IV handling for cts-cbc-aes-ce and cts-cbc-aes-neon is not consistent with the C implementation for CTS such as cts(cbc-aes-ce) and cts(cbc-aes- neon). For example, assume e