Hello,
On 14.01.2025 04:15, Herbert Xu wrote:
> On Fri, Jan 10, 2025 at 06:22:40PM +, Michael Kelley wrote:
>
> Thanks for testing! The patch needs one more change though as
> moving the atomic_inc outside of the lock was a bad idea on my
> part. This could cause atomic_inc/atomic_dec to be
On Tue, Jan 14, 2025 at 11:15:19AM +0800, Herbert Xu wrote:
Hi Herbert,
> Thanks for testing! The patch needs one more change though as
> moving the atomic_inc outside of the lock was a bad idea on my
> part. This could cause atomic_inc/atomic_dec to be reordered
> thus resulting in an underflow
On Wed, Jan 15, 2025 at 07:15:46AM -0800, Breno Leitao wrote:
>
> Something like the following (not tested):
>
> diff --git a/lib/rhashtable.c b/lib/rhashtable.c
> index 3e555d012ed60..5a0ec71e990ee 100644
> --- a/lib/rhashtable.c
> +++ b/lib/rhashtable.c
> @@ -554,7
On Tue, Jan 14, 2025 at 11:15:19AM +0800, Herbert Xu wrote:
> On Fri, Jan 10, 2025 at 06:22:40PM +, Michael Kelley wrote:
> >
> > This patch passes my tests. I'm doing a narrow test to verify that
> > the boot failure when opening the Mellanox NIC is no longer occurring.
> > I also unloaded/rel
From: Herbert Xu Sent: Monday, January 13, 2025
7:15 PM
>
> On Fri, Jan 10, 2025 at 06:22:40PM +, Michael Kelley wrote:
> >
> > This patch passes my tests. I'm doing a narrow test to verify that
> > the boot failure when opening the Mellanox NIC is no longer occurring.
> > I also unloaded/re
On Fri, Jan 10, 2025 at 06:22:40PM +, Michael Kelley wrote:
>
> This patch passes my tests. I'm doing a narrow test to verify that
> the boot failure when opening the Mellanox NIC is no longer occurring.
> I also unloaded/reloaded the mlx5 driver a couple of times. For good
> measure, I then di
