Re: [v2 PATCH] padata: Use RCU when fetching pd from do_serial

2019-07-17 Thread Herbert Xu
On Wed, Jul 17, 2019 at 10:36:41AM +0200, Steffen Klassert wrote: > > > This patch fixes it by using RCU just as we do in padata_do_parallel. > > RCU alone won't help because if some object is queued for async > crypto, we left the RCU protected aera. I think padata_do_serial > needs to do RCU and

Re: [v2 PATCH] padata: Use RCU when fetching pd from do_serial

2019-07-17 Thread Steffen Klassert
On Tue, Jul 16, 2019 at 09:23:45PM +0800, Herbert Xu wrote: > On Tue, Jul 16, 2019 at 09:09:28PM +0800, Herbert Xu wrote: > > > > Hmm, it doesn't work because the refcnt is attached to the old > > pd. That shouldn't be a problem though as we could simply ignore > > the refcnt in padata_flush_queue

[v2 PATCH] padata: Use RCU when fetching pd from do_serial

2019-07-16 Thread Herbert Xu
On Tue, Jul 16, 2019 at 09:09:28PM +0800, Herbert Xu wrote: > > Hmm, it doesn't work because the refcnt is attached to the old > pd. That shouldn't be a problem though as we could simply ignore > the refcnt in padata_flush_queue. This should fix it: ---8<--- The function padata_do_serial uses pa