Re: [v2 PATCH] padata: Replace delayed timer with immediate workqueue in padata_reorder

2019-07-19 Thread Herbert Xu
On Fri, Jul 19, 2019 at 10:37:21AM -0400, Daniel Jordan wrote: > > If I'm not missing anything, still looks like get_cpu() and reorder_via_wq no > longer have an effect with this patch and can be removed. You're right that they're not needed. But we shouldn't mix clean-ups with substantial change

Re: [v2 PATCH] padata: Replace delayed timer with immediate workqueue in padata_reorder

2019-07-19 Thread Daniel Jordan
On Thu, Jul 18, 2019 at 11:01:46PM +0800, Herbert Xu wrote: > @@ -376,9 +325,8 @@ void padata_do_serial(struct padata_priv *padata) > > cpu = get_cpu(); > > - /* We need to run on the same CPU padata_do_parallel(.., padata, ..) > - * was called on -- or, at least, enqueue the pad

[v2 PATCH] padata: Replace delayed timer with immediate workqueue in padata_reorder

2019-07-18 Thread Herbert Xu
The function padata_reorder will use a timer when it cannot progress while completed jobs are outstanding (pd->reorder_objects > 0). This is suboptimal as if we do end up using the timer then it would have introduced a gratuitous delay of one second. In fact we can easily distinguish between whet