Re: [sparc64] crc32c misbehave

2017-05-31 Thread David Miller
From: David Miller Date: Wed, 31 May 2017 11:53:35 -0400 (EDT) > Can you try something like disabling cpu IRQs around the crc32c() function > in lib/libcrc32c.c? Something like: > > u32 retval; > > local_irq_disable(); > > shash->tfm = tfm; > shash->flags = 0; >

Re: [sparc64] crc32c misbehave

2017-05-31 Thread David Miller
From: Anatoly Pugachev Date: Wed, 31 May 2017 14:56:52 +0300 > While debugging occasional crc32c checksum errors with xfs disk reads on > sparc64 (T5 [sun4v] 3.6 GHz CPU ldom, debian unstable/sid), Eric have found > that crc32c sometimes returns wrong checksum for data. Eric made a simple > test

Re: [sparc64] crc32c misbehave

2017-05-31 Thread Anatoly Pugachev
A bit more on testing machines: kernel on T5 ldom ttip is git kernel: Linux ttip 4.12.0-rc3-00011-gf511c0b17b08 #327 SMP Wed May 31 12:54:02 MSK 2017 sparc64 GNU/Linux kernel on v215 is debian sid kernel: Linux v215 4.9.0-3-sparc64-smp #1 SMP Debian 4.9.25-1 (2017-05-02) sparc64 GNU/Linux mato

Re: [sparc64] crc32c misbehave

2017-05-31 Thread Anatoly Pugachev
Hello! While debugging occasional crc32c checksum errors with xfs disk reads on sparc64 (T5 [sun4v] 3.6 GHz CPU ldom, debian unstable/sid), Eric have found that crc32c sometimes returns wrong checksum for data. Eric made a simple test kernel module (included), which produce the following results o