Re: [bug] sha1-avx2 and read beyond

2017-07-03 Thread Herbert Xu
On Mon, Jul 03, 2017 at 08:33:44PM +0800, Herbert Xu wrote: > On Sat, Jun 24, 2017 at 12:56:52AM +, Albrekht, Ilya wrote: > > Hello all, > > > > I'm sorry for late reply (I was out of office for a month). > > > > It's been a while since we touched this code. We are going to do our best > > t

Re: [bug] sha1-avx2 and read beyond

2017-07-03 Thread Herbert Xu
On Sat, Jun 24, 2017 at 12:56:52AM +, Albrekht, Ilya wrote: > Hello all, > > I'm sorry for late reply (I was out of office for a month). > > It's been a while since we touched this code. We are going to do our best to > support it. I'll be back to the office earlier next week and will figure

RE: [bug] sha1-avx2 and read beyond

2017-06-23 Thread Albrekht, Ilya
linux.intel.com; ma...@denx.de Subject: Re: [bug] sha1-avx2 and read beyond On 06/23/2017 01:48 AM, Jan Stancek wrote: > > > - Original Message - >> On Wed, May 24, 2017 at 08:46:57AM -0400, Jan Stancek wrote: >>> >>> >>> - Original Message --

Re: [bug] sha1-avx2 and read beyond

2017-06-23 Thread Tim Chen
On 06/23/2017 01:48 AM, Jan Stancek wrote: > > > - Original Message - >> On Wed, May 24, 2017 at 08:46:57AM -0400, Jan Stancek wrote: >>> >>> >>> - Original Message - Hi, I'm seeing rare crashes during NFS cthon with krb5 auth. After some digging I arrived at p

Re: [bug] sha1-avx2 and read beyond

2017-06-23 Thread Herbert Xu
On Fri, Jun 23, 2017 at 04:48:51AM -0400, Jan Stancek wrote: > > So I take it my workaround patch [1] is not acceptable in > short-term as well? > > [1] http://marc.info/?l=linux-crypto-vger&m=149373371023377 As we don't have a proper fix we may not be aware of the complete scope of the problem (

Re: [bug] sha1-avx2 and read beyond

2017-06-23 Thread Jan Stancek
- Original Message - > On Wed, May 24, 2017 at 08:46:57AM -0400, Jan Stancek wrote: > > > > > > - Original Message - > > > Hi, > > > > > > I'm seeing rare crashes during NFS cthon with krb5 auth. After > > > some digging I arrived at potential problem with sha1-avx2. > > > > A

Re: [bug] sha1-avx2 and read beyond

2017-06-23 Thread Herbert Xu
On Wed, May 24, 2017 at 08:46:57AM -0400, Jan Stancek wrote: > > > - Original Message - > > Hi, > > > > I'm seeing rare crashes during NFS cthon with krb5 auth. After > > some digging I arrived at potential problem with sha1-avx2. > > Adding more sha1_avx2 experts to CC. > > > > > Pro

Re: [bug] sha1-avx2 and read beyond

2017-05-24 Thread Jan Stancek
- Original Message - > Hi, > > I'm seeing rare crashes during NFS cthon with krb5 auth. After > some digging I arrived at potential problem with sha1-avx2. Adding more sha1_avx2 experts to CC. > > Problem appears to be that sha1_transform_avx2() reads beyond > number of blocks you pas

Re: [bug] sha1-avx2 and read beyond

2017-05-02 Thread Jan Stancek
On 04/30/2017 01:04 AM, Jan Stancek wrote: > Hi, > > I'm seeing rare crashes during NFS cthon with krb5 auth. After > some digging I arrived at potential problem with sha1-avx2. > > Problem appears to be that sha1_transform_avx2() reads beyond > number of blocks you pass, if it is an odd number.

[bug] sha1-avx2 and read beyond

2017-04-29 Thread Jan Stancek
Hi, I'm seeing rare crashes during NFS cthon with krb5 auth. After some digging I arrived at potential problem with sha1-avx2. Problem appears to be that sha1_transform_avx2() reads beyond number of blocks you pass, if it is an odd number. It appears to try read one block more. This creates a pro