Re: [RFC PATCH v2 0/4] Exporting existing crypto API code through zinc

2018-11-20 Thread Herbert Xu
On Tue, Nov 20, 2018 at 05:24:41PM +0100, Jason A. Donenfeld wrote: > On Tue, Nov 20, 2018 at 3:19 PM Herbert Xu > wrote: > > Yes. In fact it's used for FIPS certification testing. > > Sure, nobody sane should be doing it. But when it comes to > > government certification... :) > > The kernel

Re: [RFC PATCH v2 0/4] Exporting existing crypto API code through zinc

2018-11-20 Thread Herbert Xu
On Tue, Nov 20, 2018 at 05:18:24PM +0100, Jason A. Donenfeld wrote: > > N'ack. As I mentioned in the last email, this really isn't okay, and > mostly defeats the purpose of Zinc in the first place, adding > complexity in a discombobulated half-baked way. Your proposal seems to > be the worst of all

Re: [RFC PATCH v2 0/4] Exporting existing crypto API code through zinc

2018-11-20 Thread Theodore Y. Ts'o
On Tue, Nov 20, 2018 at 05:24:41PM +0100, Jason A. Donenfeld wrote: > On Tue, Nov 20, 2018 at 3:19 PM Herbert Xu > wrote: > > Yes. In fact it's used for FIPS certification testing. > > Sure, nobody sane should be doing it. But when it comes to > > government certification... :) > > The kernel

Re: [RFC PATCH v2 0/4] Exporting existing crypto API code through zinc

2018-11-20 Thread Jason A. Donenfeld
On Tue, Nov 20, 2018 at 3:19 PM Herbert Xu wrote: > Yes. In fact it's used for FIPS certification testing. > Sure, nobody sane should be doing it. But when it comes to > government certification... :) The kernel does not aim toward any FIPS certification, and we're not going to start bloating o

Re: [RFC PATCH v2 0/4] Exporting existing crypto API code through zinc

2018-11-20 Thread Jason A. Donenfeld
Hi Herbert, On Tue, Nov 20, 2018 at 7:02 AM Herbert Xu wrote: > Here is an updated version demonstrating how we could access the > accelerated versions of chacha20. It also includes a final patch > to deposit the new zinc version of x86-64 chacha20 into > arch/x86/crypto where it can be used by

Re: [RFC PATCH v2 0/4] Exporting existing crypto API code through zinc

2018-11-20 Thread Herbert Xu
Hi Ard: On Tue, Nov 20, 2018 at 11:32:05AM +0100, Ard Biesheuvel wrote: > > > 1. The crypto API algorithms remain individually accessible, this > > is crucial as these algorithm names are exported to user-space so > > changing the names to foo-zinc is not going to work. > > Are you saying user sp

Re: [RFC PATCH v2 0/4] Exporting existing crypto API code through zinc

2018-11-20 Thread Ard Biesheuvel
On Tue, 20 Nov 2018 at 07:02, Herbert Xu wrote: > > On Mon, Nov 19, 2018 at 01:24:51PM +0800, Herbert Xu wrote: > > > > In response to Martin's patch-set which I merged last week, I think > > here is quick way out for the zinc interface. > > > > Going through the past zinc discussions it would app

[RFC PATCH v2 0/4] Exporting existing crypto API code through zinc

2018-11-19 Thread Herbert Xu
On Mon, Nov 19, 2018 at 01:24:51PM +0800, Herbert Xu wrote: > > In response to Martin's patch-set which I merged last week, I think > here is quick way out for the zinc interface. > > Going through the past zinc discussions it would appear that > everybody is quite happy with the zinc interface pe