Re: [RFC PATCH v2] Add VMAC(AES) to Linux for intel_txt support

2009-08-20 Thread Herbert Xu
On Sat, Aug 15, 2009 at 12:48:31AM +0800, Shane Wang wrote: > > +/* x86_64 or amd64 */ > +#if (__GNUC__ && (__x86_64__ || __amd64__)) > + > +#define ADD128(rh, rl, ih, il) > \ > + asm ("addq %3, %1 \n\t" \ >

Re: [RFC PATCH v2] Add VMAC(AES) to Linux for intel_txt support

2009-08-14 Thread Shane Wang
Hi Herbert, I have updated it. How does this patch look? Please comment. Thanks a lot. Shane Signed-off-by: Shane Wang Signed-off-by: Joseph Cihula diff -r 7ccb4aa6908f crypto/Kconfig --- a/crypto/KconfigWed Aug 05 15:43:38 2009 -0700 +++ b/crypto/KconfigFri Aug 14 03:54:21 2009 -07

RE: [RFC PATCH v2] Add VMAC(AES) to Linux for intel_txt support

2009-08-14 Thread Wang, Shane
Herbert Xu wrote: > On Tue, Aug 11, 2009 at 01:05:57AM +0800, Shane Wang wrote: >> >> For the comment >>> This is unnecessary. Please use the standard kernel helpers >>> from asm/byteorder.h (which you get by including linux/kernel.h). >> The current code distinguishes some macro implementations

Re: [RFC PATCH v2] Add VMAC(AES) to Linux for intel_txt support

2009-08-13 Thread Herbert Xu
On Tue, Aug 11, 2009 at 01:05:57AM +0800, Shane Wang wrote: > > For the comment > > This is unnecessary. Please use the standard kernel helpers > > from asm/byteorder.h (which you get by including linux/kernel.h). > The current code distinguishes some macro implementations according to > differen

[RFC PATCH v2] Add VMAC(AES) to Linux for intel_txt support

2009-08-10 Thread Shane Wang
Hi community, I have updated the patch. For the comment > This is unnecessary. Please use the standard kernel helpers > from asm/byteorder.h (which you get by including linux/kernel.h). The current code distinguishes some macro implementations according to different platforms to improve the MA