Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-08 Thread Ard Biesheuvel
On Sat, 8 Jun 2019 at 16:37, Ard Biesheuvel wrote: > > On Sat, 8 Jun 2019 at 15:03, Sandy Harris wrote: > > > > First off, it is not clear we should implement WEP at all since it is > > fatally flawed. This has been known for about a decade, there have > > been at least two better algorithms adde

Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-08 Thread Ard Biesheuvel
On Sat, 8 Jun 2019 at 15:03, Sandy Harris wrote: > > First off, it is not clear we should implement WEP at all since it is > fatally flawed. This has been known for about a decade, there have > been at least two better algorithms added to the standards, & the only > reason anyone would need WEP to

Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-08 Thread Sandy Harris
First off, it is not clear we should implement WEP at all since it is fatally flawed. This has been known for about a decade, there have been at least two better algorithms added to the standards, & the only reason anyone would need WEP today would be to connect to an old router in an obviously ins

Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-07 Thread Denis Kenzior
Hi Eric, On 06/07/2019 05:40 PM, Eric Biggers wrote: On Fri, Jun 07, 2019 at 04:54:04PM -0500, Denis Kenzior wrote: Hi Eric, On 06/07/2019 04:41 PM, Eric Biggers wrote: On Fri, Jun 07, 2019 at 04:28:59PM -0500, Denis Kenzior wrote: Hi Eric, On 06/07/2019 04:15 PM, Eric Biggers wrote: On Fr

Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-07 Thread Eric Biggers
On Fri, Jun 07, 2019 at 04:54:04PM -0500, Denis Kenzior wrote: > Hi Eric, > > On 06/07/2019 04:41 PM, Eric Biggers wrote: > > On Fri, Jun 07, 2019 at 04:28:59PM -0500, Denis Kenzior wrote: > > > Hi Eric, > > > > > > On 06/07/2019 04:15 PM, Eric Biggers wrote: > > > > On Fri, Jun 07, 2019 at 03:45

Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-07 Thread Denis Kenzior
Hi Eric, On 06/07/2019 04:41 PM, Eric Biggers wrote: On Fri, Jun 07, 2019 at 04:28:59PM -0500, Denis Kenzior wrote: Hi Eric, On 06/07/2019 04:15 PM, Eric Biggers wrote: On Fri, Jun 07, 2019 at 03:45:45PM -0500, Denis Kenzior wrote: Hi Ard, Ah ok, good to know. That does imply that the dri

Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-07 Thread Eric Biggers
On Fri, Jun 07, 2019 at 04:28:59PM -0500, Denis Kenzior wrote: > Hi Eric, > > On 06/07/2019 04:15 PM, Eric Biggers wrote: > > On Fri, Jun 07, 2019 at 03:45:45PM -0500, Denis Kenzior wrote: > > > Hi Ard, > > > > > > > > > > > Ah ok, good to know. That does imply that the driver is not entirely >

Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-07 Thread Denis Kenzior
Hi Eric, On 06/07/2019 04:15 PM, Eric Biggers wrote: On Fri, Jun 07, 2019 at 03:45:45PM -0500, Denis Kenzior wrote: Hi Ard, Ah ok, good to know. That does imply that the driver is not entirely broken, which is good news I suppose. Not entirely, but we did have to resort to using multiple

Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-07 Thread Eric Biggers
On Fri, Jun 07, 2019 at 03:45:45PM -0500, Denis Kenzior wrote: > Hi Ard, > > > > > Ah ok, good to know. That does imply that the driver is not entirely > > broken, which is good news I suppose. > > > > Not entirely, but we did have to resort to using multiple sockets, otherwise > parallel encry

Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-07 Thread Denis Kenzior
Hi Ard, Ah ok, good to know. That does imply that the driver is not entirely broken, which is good news I suppose. Not entirely, but we did have to resort to using multiple sockets, otherwise parallel encrypt/decrypt operations on the socket would result in invalid behavior. Probably due

Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-07 Thread Ard Biesheuvel
On Fri, 7 Jun 2019 at 22:24, Marcel Holtmann wrote: > > Hi Eric, > > >> One of the issues that I would like to see addressed in the crypto API > >> is they way the cipher abstraction is used. In general, a cipher should > >> never be used directly, and so it would be much better to clean up the >

Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-07 Thread Marcel Holtmann
Hi Eric, >> One of the issues that I would like to see addressed in the crypto API >> is they way the cipher abstraction is used. In general, a cipher should >> never be used directly, and so it would be much better to clean up the >> existing uses of ciphers outside of the crypto subsystem itself

Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-07 Thread Ard Biesheuvel
On Fri, 7 Jun 2019 at 19:59, Eric Biggers wrote: > > On Fri, Jun 07, 2019 at 04:49:41PM +0200, Ard Biesheuvel wrote: > > One of the issues that I would like to see addressed in the crypto API > > is they way the cipher abstraction is used. In general, a cipher should > > never be used directly, an

Re: [RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-07 Thread Eric Biggers
On Fri, Jun 07, 2019 at 04:49:41PM +0200, Ard Biesheuvel wrote: > One of the issues that I would like to see addressed in the crypto API > is they way the cipher abstraction is used. In general, a cipher should > never be used directly, and so it would be much better to clean up the > existing uses

[RFC PATCH 0/3] move WEP implementation to skcipher interface

2019-06-07 Thread Ard Biesheuvel
One of the issues that I would like to see addressed in the crypto API is they way the cipher abstraction is used. In general, a cipher should never be used directly, and so it would be much better to clean up the existing uses of ciphers outside of the crypto subsystem itself, so that we can make