RE: [RFC PATCH] net: ipv4: move tcp_fastopen server side code to SipHash library

2019-06-14 Thread David Laight
From: Ard Biesheuvel > Sent: 14 June 2019 12:15 > (fix Eric's email address) > > On Fri, 14 Jun 2019 at 13:14, Ard Biesheuvel > wrote: > > > > Using a bare block cipher in non-crypto code is almost always a bad idea, > > not only for security reasons (and we've seen some examples of this in > >

Re: [RFC PATCH] net: ipv4: move tcp_fastopen server side code to SipHash library

2019-06-14 Thread Eric Dumazet
On Fri, Jun 14, 2019 at 4:14 AM Ard Biesheuvel wrote: > > Using a bare block cipher in non-crypto code is almost always a bad idea, > not only for security reasons (and we've seen some examples of this in > the kernel in the past), but also for performance reasons. > > In the TCP fastopen case, we

Re: [RFC PATCH] net: ipv4: move tcp_fastopen server side code to SipHash library

2019-06-14 Thread Ard Biesheuvel
(fix Eric's email address) On Fri, 14 Jun 2019 at 13:14, Ard Biesheuvel wrote: > > Using a bare block cipher in non-crypto code is almost always a bad idea, > not only for security reasons (and we've seen some examples of this in > the kernel in the past), but also for performance reasons. > > In

[RFC PATCH] net: ipv4: move tcp_fastopen server side code to SipHash library

2019-06-14 Thread Ard Biesheuvel
Using a bare block cipher in non-crypto code is almost always a bad idea, not only for security reasons (and we've seen some examples of this in the kernel in the past), but also for performance reasons. In the TCP fastopen case, we call into the bare AES block cipher one or two times (depending o