Re: [RESEND PATCH 05/10] crypto: sha256_generic: Export the Transform function

2019-06-27 Thread Keerthy
On 28/06/19 10:39 AM, Eric Biggers wrote: On Fri, Jun 28, 2019 at 09:57:40AM +0530, Keerthy wrote: The transform function can be used as is by other crypto drivers that need to transform the 256 bit key using cpu. Hence export it. What is this supposed to mean? SHA-256 is an unkeyed hash f

Re: [RESEND PATCH 05/10] crypto: sha256_generic: Export the Transform function

2019-06-27 Thread Eric Biggers
On Fri, Jun 28, 2019 at 09:57:40AM +0530, Keerthy wrote: > The transform function can be used as is by other crypto > drivers that need to transform the 256 bit key using cpu. > Hence export it. What is this supposed to mean? SHA-256 is an unkeyed hash function. Also, you need to actually explai

[RESEND PATCH 05/10] crypto: sha256_generic: Export the Transform function

2019-06-27 Thread Keerthy
The transform function can be used as is by other crypto drivers that need to transform the 256 bit key using cpu. Hence export it. Signed-off-by: Keerthy --- crypto/sha256_generic.c | 3 ++- include/crypto/sha.h| 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/crypto/sha2