Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-15 Thread Karel Balej
#regzbot title: SHA1 support removal breaks iwd's ability to connect to eduroam #regzbot monitor: https://lore.kernel.org/all/20240313233227.56391-1-ebigg...@kernel.org/ #regzbot monitor: https://lore.kernel.org/all/czshruij4rkl.34t4easv5d...@matfyz.cz/ #regzbot link: https://lore.kernel.org/iwd

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-14 Thread Ard Biesheuvel
On Thu, 14 Mar 2024 at 21:20, Eric Biggers wrote: > > On Thu, Mar 14, 2024 at 04:52:47AM -0700, James Prestwood wrote: > > IWD uses AF_ALG/keyctl for _all_ its crypto, cipher, and checksum needs. > > Anything that wifi requires as far as crypto goes IWD uses the kernel, > > except ECC is the only

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-14 Thread Eric Biggers
On Thu, Mar 14, 2024 at 04:52:47AM -0700, James Prestwood wrote: > IWD uses AF_ALG/keyctl for _all_ its crypto, cipher, and checksum needs. > Anything that wifi requires as far as crypto goes IWD uses the kernel, > except ECC is the only exception. The entire list of crypto requirements > (for full

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-14 Thread James Bottomley
On Thu, 2024-03-14 at 04:52 -0700, James Prestwood wrote: > I'm also not entirely sure why this stuff continues to be removed > from the kernel. First MD4, then it got reverted, then this (now > reverted, thanks). Both cases there was not clear justification of > why it was being removed. I think

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-14 Thread James Prestwood
Hi, On 3/13/24 4:06 PM, Eric Biggers wrote: On Wed, Mar 13, 2024 at 03:51:10PM -0700, Jeff Johnson wrote: On 3/13/2024 3:10 PM, Eric Biggers wrote: On Wed, Mar 13, 2024 at 02:17:29PM -0700, James Prestwood wrote: Hi, On 3/13/24 1:22 PM, Eric Biggers wrote: On Wed, Mar 13, 2024 at 01:12:54PM

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-13 Thread Eric Biggers
On Wed, Mar 13, 2024 at 04:06:11PM -0700, Eric Biggers wrote: > On Wed, Mar 13, 2024 at 03:51:10PM -0700, Jeff Johnson wrote: > > On 3/13/2024 3:10 PM, Eric Biggers wrote: > > > On Wed, Mar 13, 2024 at 02:17:29PM -0700, James Prestwood wrote: > > >> Hi, > > >> > > >> On 3/13/24 1:22 PM, Eric Bigger

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-13 Thread Eric Biggers
On Wed, Mar 13, 2024 at 03:51:10PM -0700, Jeff Johnson wrote: > On 3/13/2024 3:10 PM, Eric Biggers wrote: > > On Wed, Mar 13, 2024 at 02:17:29PM -0700, James Prestwood wrote: > >> Hi, > >> > >> On 3/13/24 1:22 PM, Eric Biggers wrote: > >>> On Wed, Mar 13, 2024 at 01:12:54PM -0700, James Prestwood w

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-13 Thread Jeff Johnson
On 3/13/2024 3:10 PM, Eric Biggers wrote: > On Wed, Mar 13, 2024 at 02:17:29PM -0700, James Prestwood wrote: >> Hi, >> >> On 3/13/24 1:22 PM, Eric Biggers wrote: >>> On Wed, Mar 13, 2024 at 01:12:54PM -0700, James Prestwood wrote: Hi, On 3/13/24 12:44 PM, Eric Biggers wrote: > On

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-13 Thread Eric Biggers
On Wed, Mar 13, 2024 at 02:17:29PM -0700, James Prestwood wrote: > Hi, > > On 3/13/24 1:22 PM, Eric Biggers wrote: > > On Wed, Mar 13, 2024 at 01:12:54PM -0700, James Prestwood wrote: > > > Hi, > > > > > > On 3/13/24 12:44 PM, Eric Biggers wrote: > > > > On Wed, Mar 13, 2024 at 10:26:06AM -0700,

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-13 Thread James Prestwood
Hi, On 3/13/24 1:22 PM, Eric Biggers wrote: On Wed, Mar 13, 2024 at 01:12:54PM -0700, James Prestwood wrote: Hi, On 3/13/24 12:44 PM, Eric Biggers wrote: On Wed, Mar 13, 2024 at 10:26:06AM -0700, James Prestwood wrote: Hi, On 3/13/24 1:56 AM, Johannes Berg wrote: Not sure why you're CC'ing

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-13 Thread Eric Biggers
On Wed, Mar 13, 2024 at 01:12:54PM -0700, James Prestwood wrote: > Hi, > > On 3/13/24 12:44 PM, Eric Biggers wrote: > > On Wed, Mar 13, 2024 at 10:26:06AM -0700, James Prestwood wrote: > > > Hi, > > > > > > On 3/13/24 1:56 AM, Johannes Berg wrote: > > > > Not sure why you're CC'ing the world, but

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-13 Thread James Prestwood
Hi, On 3/13/24 12:44 PM, Eric Biggers wrote: On Wed, Mar 13, 2024 at 10:26:06AM -0700, James Prestwood wrote: Hi, On 3/13/24 1:56 AM, Johannes Berg wrote: Not sure why you're CC'ing the world, but I guess adding a few more doesn't hurt ... On Wed, 2024-03-13 at 09:50 +0100, Karel Balej wrote

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-13 Thread Karel Balej
Thank you all for your feedback so far. Since it seems that this really is a regression on the kernel side, let me add the appropriate list to Cc and tag this: #regzbot introduced: 16ab7cb5825f Best regards, K. B.

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-13 Thread Eric Biggers
On Wed, Mar 13, 2024 at 10:26:06AM -0700, James Prestwood wrote: > Hi, > > On 3/13/24 1:56 AM, Johannes Berg wrote: > > Not sure why you're CC'ing the world, but I guess adding a few more > > doesn't hurt ... > > > > On Wed, 2024-03-13 at 09:50 +0100, Karel Balej wrote: > > > and I use iwd > >

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-13 Thread Michael Yartys
Hi This came in via the iwd mailing list, and I would like to add some small a detail as I also experience this issue on my university eduroam network. I've verified that the certificate chain doesn't contain SHA-1 signed certificates, so the update breaks more than just SHA-1. Michael On

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-13 Thread James Prestwood
Hi, On 3/13/24 1:56 AM, Johannes Berg wrote: Not sure why you're CC'ing the world, but I guess adding a few more doesn't hurt ... On Wed, 2024-03-13 at 09:50 +0100, Karel Balej wrote: and I use iwd This is your problem, the wireless stack in the kernel doesn't use any kernel crypto code for

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-13 Thread Johannes Berg
Not sure why you're CC'ing the world, but I guess adding a few more doesn't hurt ... On Wed, 2024-03-13 at 09:50 +0100, Karel Balej wrote: > > and I use iwd This is your problem, the wireless stack in the kernel doesn't use any kernel crypto code for 802.1X. I suppose iwd wants to use the kern

[REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-13 Thread Karel Balej
Dimitri, Johannes, ever since upgrading to Linux v6.7 I am unable to connect to a 802.1X wireless network (specifically, eduroam). In my dmesg, the following messages appear: [ 68.161621] wlan0: authenticate with xx:xx:xx:xx:xx:xx (local address=xx:xx:xx:xx:xx:xx) [ 68.163733