RE: [PATCHv2] crypto: inside-secure - Fix unused variable warning when CONFIG_PCI=n

2019-09-06 Thread Pascal Van Leeuwen
pto: inside-secure - Fix unused variable warning > when > CONFIG_PCI=n > > On Fri, Sep 06, 2019 at 01:01:19PM +, Pascal Van Leeuwen wrote: > > > > I explicitly DON'T want to abort if the PCI registration fails, > > since that may be irrelevant if the OF re

Re: [PATCHv2] crypto: inside-secure - Fix unused variable warning when CONFIG_PCI=n

2019-09-06 Thread Herbert Xu
On Fri, Sep 06, 2019 at 01:01:19PM +, Pascal Van Leeuwen wrote: > > I explicitly DON'T want to abort if the PCI registration fails, > since that may be irrelevant if the OF registration passes AND > the device actually happens to be Device Tree. > So not checking the result value is on purpose

RE: [PATCHv2] crypto: inside-secure - Fix unused variable warning when CONFIG_PCI=n

2019-09-06 Thread Pascal Van Leeuwen
Van Leeuwen ; Bjorn Helgaas > > Subject: Re: [PATCHv2] crypto: inside-secure - Fix unused variable warning > when > CONFIG_PCI=n > > On Fri, Sep 06, 2019 at 10:07:23AM +0200, Pascal van Leeuwen wrote: > > > > diff --git a/drivers/crypto/inside-secure/safexcel.c &

Re: [PATCHv2] crypto: inside-secure - Fix unused variable warning when CONFIG_PCI=n

2019-09-06 Thread Herbert Xu
On Fri, Sep 06, 2019 at 10:07:23AM +0200, Pascal van Leeuwen wrote: > > diff --git a/drivers/crypto/inside-secure/safexcel.c > b/drivers/crypto/inside-secure/safexcel.c > index e12a2a3..2331b31 100644 > --- a/drivers/crypto/inside-secure/safexcel.c > +++ b/drivers/crypto/inside-secure/safexcel.c >

[PATCHv2] crypto: inside-secure - Fix unused variable warning when CONFIG_PCI=n

2019-09-06 Thread Pascal van Leeuwen
This patch fixes an unused variable warning from the compiler when the driver is being compiled without PCI support in the kernel. changes since v1: - capture the platform_register_driver error code as well - actually return the (last) error code - swapped registration to do PCI first as that's ju