Re: [PATCH v8] KEYS: Add a list for unreferenced keys

2025-04-12 Thread Jarkko Sakkinen
On Sat, Apr 12, 2025 at 04:30:24AM +0300, Jarkko Sakkinen wrote: > On Fri, Apr 11, 2025 at 11:37:25PM +0300, Jarkko Sakkinen wrote: > > On Fri, Apr 11, 2025 at 04:59:11PM +0100, David Howells wrote: > > > Jarkko Sakkinen wrote: > > > > > > > + spin_lock_irqsave(&key_graveyard_lock, flags);

Re: [PATCH v8] KEYS: Add a list for unreferenced keys

2025-04-11 Thread Jarkko Sakkinen
On Fri, Apr 11, 2025 at 11:37:25PM +0300, Jarkko Sakkinen wrote: > On Fri, Apr 11, 2025 at 04:59:11PM +0100, David Howells wrote: > > Jarkko Sakkinen wrote: > > > > > + spin_lock_irqsave(&key_graveyard_lock, flags); > > > + list_splice_init(&key_graveyard, &graveyard); > > > + spin_unlock_irqrest

Re: [PATCH v8] KEYS: Add a list for unreferenced keys

2025-04-11 Thread Jarkko Sakkinen
On Fri, Apr 11, 2025 at 11:37:25PM +0300, Jarkko Sakkinen wrote: > > This is going to enable and disable interrupts twice and that can be > > expensive, depending on the arch. I wonder if it would be better to do: > > > > local_irq_save(flags); > > spin_loc

Re: [PATCH v8] KEYS: Add a list for unreferenced keys

2025-04-11 Thread Jarkko Sakkinen
On Fri, Apr 11, 2025 at 04:59:11PM +0100, David Howells wrote: > Jarkko Sakkinen wrote: > > > + spin_lock_irqsave(&key_graveyard_lock, flags); > > + list_splice_init(&key_graveyard, &graveyard); > > + spin_unlock_irqrestore(&key_graveyard_lock, flags); > > I would wrap this bit in a check

Re: [PATCH v8] KEYS: Add a list for unreferenced keys

2025-04-11 Thread David Howells
Jarkko Sakkinen wrote: > + spin_lock_irqsave(&key_graveyard_lock, flags); > + list_splice_init(&key_graveyard, &graveyard); > + spin_unlock_irqrestore(&key_graveyard_lock, flags); I would wrap this bit in a check to see if key_graveyard is empty so that we can avoid disabling irqs an

Re: [PATCH v8] KEYS: Add a list for unreferenced keys

2025-04-10 Thread Jarkko Sakkinen
On Tue, Apr 08, 2025 at 07:01:47PM +0300, Jarkko Sakkinen wrote: > On Mon, Apr 07, 2025 at 03:58:01PM +0300, Jarkko Sakkinen wrote: > > From: Jarkko Sakkinen > > > > Add an isolated list of unreferenced keys to be queued for deletion, and > > try to pin the keys in the garbage collector before pr

Re: [PATCH v8] KEYS: Add a list for unreferenced keys

2025-04-08 Thread Jarkko Sakkinen
On Mon, Apr 07, 2025 at 03:58:01PM +0300, Jarkko Sakkinen wrote: > From: Jarkko Sakkinen > > Add an isolated list of unreferenced keys to be queued for deletion, and > try to pin the keys in the garbage collector before processing anything. > Skip unpinnable keys. > > Use this list for blocking

[PATCH v8] KEYS: Add a list for unreferenced keys

2025-04-07 Thread Jarkko Sakkinen
From: Jarkko Sakkinen Add an isolated list of unreferenced keys to be queued for deletion, and try to pin the keys in the garbage collector before processing anything. Skip unpinnable keys. Use this list for blocking the reaping process during the teardown: 1. First off, the keys added to `keys