RE: [PATCH v7 6/8] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave

2012-09-04 Thread Liu Qiang-B32616
r.kernel.org; vinod.k...@intel.com; Phillips Kim-R1AAHA; > herb...@gondor.hengli.com.au; da...@davemloft.net; a...@arndb.de; > gre...@linuxfoundation.org; Li Yang-R58472; Tabi Timur-B04825 > Subject: Re: [PATCH v7 6/8] fsl-dma: use spin_lock_bh to instead of > spin_lock_irqsave &g

Re: [PATCH v7 6/8] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave

2012-09-02 Thread Dan Williams
On Thu, Aug 9, 2012 at 1:23 AM, wrote: > From: Qiang Liu > > The use of spin_lock_irqsave() is a stronger locking mechanism than is > required throughout the driver. The minimum locking required should be > used instead. Interrupts will be turned off and context will be saved, > there is needles

[PATCH v7 6/8] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave

2012-08-09 Thread qiang.liu
From: Qiang Liu The use of spin_lock_irqsave() is a stronger locking mechanism than is required throughout the driver. The minimum locking required should be used instead. Interrupts will be turned off and context will be saved, there is needless to use irqsave. Change all instances of spin_lock