Re: [PATCH v7 1/6] SP800-90A Deterministic Random Bit Generator

2014-05-25 Thread Stephan Mueller
Am Samstag, 24. Mai 2014, 05:10:07 schrieb Herbert Xu: Hi Herbert, > Stephan Mueller wrote: > > + memset(&drbg_algs[i], 0, sizeof(struct crypto_alg)); > > + if (pr) { > > + memcpy(drbg_algs[i].cra_name, "drbg(pr(", 8); > > + memcpy(drbg_algs[i].cra_driver_

Re: [PATCH v7 1/6] SP800-90A Deterministic Random Bit Generator

2014-05-23 Thread Herbert Xu
Stephan Mueller wrote: > > + memset(&drbg_algs[i], 0, sizeof(struct crypto_alg)); > + if (pr) { > + memcpy(drbg_algs[i].cra_name, "drbg(pr(", 8); > + memcpy(drbg_algs[i].cra_driver_name, "drbg_pr_", 8); > + pos = 8; You shouldn't use the brack

Re: [PATCH v7 1/6] SP800-90A Deterministic Random Bit Generator

2014-05-21 Thread Stephan Mueller
Am Mittwoch, 21. Mai 2014, 06:18:58 schrieb Stephan Mueller: Hi, > +/* > + * Tests as defined in 11.3.2 in addition to the cipher tests: testing > + * of the error handling. > + * > + * Note: testing of failing seed source as defined in 11.3.2 is not > applicable + * as seed source of get_random_