Re: [PATCH v7 1/2] crypto: AF_ALG: add AEAD support

2015-01-05 Thread Stephan Mueller
Am Montag, 5. Januar 2015, 21:51:06 schrieb Herbert Xu: Hi Herbert, > On Mon, Jan 05, 2015 at 11:46:50AM +0100, Stephan Mueller wrote: > > The need for that check lies in aead_recvmsg: > > /* > > > > * first chunk of input is AD -- one scatterlist entry is one > >

Re: [PATCH v7 1/2] crypto: AF_ALG: add AEAD support

2015-01-05 Thread Stephan Mueller
Am Montag, 5. Januar 2015, 21:51:06 schrieb Herbert Xu: Hi Herbert, > On Mon, Jan 05, 2015 at 11:46:50AM +0100, Stephan Mueller wrote: > > The need for that check lies in aead_recvmsg: > > /* > > > > * first chunk of input is AD -- one scatterlist entry is one > >

Re: [PATCH v7 1/2] crypto: AF_ALG: add AEAD support

2015-01-05 Thread Herbert Xu
On Mon, Jan 05, 2015 at 11:46:50AM +0100, Stephan Mueller wrote: > > The need for that check lies in aead_recvmsg: > > /* > * first chunk of input is AD -- one scatterlist entry is one page, > * and we process only one scatterlist, the maximum size of AD is > *

Re: [PATCH v7 1/2] crypto: AF_ALG: add AEAD support

2015-01-05 Thread Stephan Mueller
Am Montag, 5. Januar 2015, 21:31:59 schrieb Herbert Xu: Hi Herbert, > On Fri, Jan 02, 2015 at 03:41:33PM +0100, Stephan Mueller wrote: > > + if (!con.aead_assoclen) > > + return -EINVAL; > > AD being zero should be fine. Ok, removed. > > > + /* aead_recvms

Re: [PATCH v7 1/2] crypto: AF_ALG: add AEAD support

2015-01-05 Thread Herbert Xu
On Fri, Jan 02, 2015 at 03:41:33PM +0100, Stephan Mueller wrote: > > + if (!con.aead_assoclen) > + return -EINVAL; AD being zero should be fine. > + /* aead_recvmsg limits the maximum AD size to one page */ > + if (con.aead_assoclen > PAGE_S

[PATCH v7 1/2] crypto: AF_ALG: add AEAD support

2015-01-02 Thread Stephan Mueller
This patch adds the AEAD support for AF_ALG. The implementation is based on algif_skcipher, but contains heavy modifications to streamline the interface for AEAD uses. To use AEAD, the user space consumer has to use the salg_type named "aead". The AEAD implementation includes some overhead to ca