Re: [PATCH v6 2/3] uacce: add uacce driver

2019-10-23 Thread Jerome Glisse
On Wed, Oct 23, 2019 at 09:42:27AM +0200, Jean-Philippe Brucker wrote: > On Fri, Oct 18, 2019 at 08:01:44PM +0800, zhangfei@foxmail.com wrote: [...] > > > > +static int uacce_fops_mmap(struct file *filep, struct vm_area_struct > > > > *vma) > > > > +{ > > > > + struct uacce_queue *q =

Re: [PATCH v6 2/3] uacce: add uacce driver

2019-10-23 Thread Jerome Glisse
On Wed, Oct 16, 2019 at 07:28:02PM +0200, Jean-Philippe Brucker wrote: [...] > > +static struct uacce_qfile_region * > > +uacce_create_region(struct uacce_queue *q, struct vm_area_struct *vma, > > + enum uacce_qfrt type, unsigned int flags) > > +{ > > + struct uacce_qfile_region *q

Re: [PATCH v6 2/3] uacce: add uacce driver

2019-10-23 Thread Jean-Philippe Brucker
On Fri, Oct 18, 2019 at 08:01:44PM +0800, zhangfei@foxmail.com wrote: > > More generally, it would be nice to use the DMA API when SVA isn't > > supported, instead of manually allocating and mapping memory with > > iommu_map(). Do we only handcraft these functions in order to have VA == > > IOV

Re: [PATCH v6 2/3] uacce: add uacce driver

2019-10-22 Thread Jerome Glisse
On Wed, Oct 16, 2019 at 04:34:32PM +0800, Zhangfei Gao wrote: > From: Kenneth Lee > > Uacce (Unified/User-space-access-intended Accelerator Framework) targets to > provide Shared Virtual Addressing (SVA) between accelerators and processes. > So accelerator can access any data structure of the mai

Re: [PATCH v6 2/3] uacce: add uacce driver

2019-10-16 Thread Jean-Philippe Brucker
Hi, I have a few comments on the overall design and some implementation details below. Could you also Cc io...@lists.linux-foundation.org on your next posting? I'm sure some subscribers would be interested and I don't think many people know about linux-accelerators yet. On Wed, Oct 16, 2019 at 0

[PATCH v6 2/3] uacce: add uacce driver

2019-10-16 Thread Zhangfei Gao
From: Kenneth Lee Uacce (Unified/User-space-access-intended Accelerator Framework) targets to provide Shared Virtual Addressing (SVA) between accelerators and processes. So accelerator can access any data structure of the main cpu. This differs from the data sharing between cpu and io device, whi