Re: [PATCH v6 12/18] drbd: Convert from ahash to shash

2018-08-06 Thread Kees Cook
On Fri, Aug 3, 2018 at 6:44 AM, Lars Ellenberg wrote: > On Thu, Aug 02, 2018 at 04:43:19PM -0700, Kees Cook wrote: >> On Tue, Jul 24, 2018 at 9:49 AM, Kees Cook wrote: >> > In preparing to remove all stack VLA usage from the kernel[1], this >> > removes the discouraged use of AHASH_REQUEST_ON_STA

Re: [PATCH v6 12/18] drbd: Convert from ahash to shash

2018-08-03 Thread Lars Ellenberg
On Thu, Aug 02, 2018 at 04:43:19PM -0700, Kees Cook wrote: > On Tue, Jul 24, 2018 at 9:49 AM, Kees Cook wrote: > > In preparing to remove all stack VLA usage from the kernel[1], this > > removes the discouraged use of AHASH_REQUEST_ON_STACK in favor of > > the smaller SHASH_DESC_ON_STACK by conver

Re: [PATCH v6 12/18] drbd: Convert from ahash to shash

2018-08-02 Thread Kees Cook
On Tue, Jul 24, 2018 at 9:49 AM, Kees Cook wrote: > In preparing to remove all stack VLA usage from the kernel[1], this > removes the discouraged use of AHASH_REQUEST_ON_STACK in favor of > the smaller SHASH_DESC_ON_STACK by converting from ahash-wrapped-shash > to direct shash. By removing a laye

[PATCH v6 12/18] drbd: Convert from ahash to shash

2018-07-24 Thread Kees Cook
In preparing to remove all stack VLA usage from the kernel[1], this removes the discouraged use of AHASH_REQUEST_ON_STACK in favor of the smaller SHASH_DESC_ON_STACK by converting from ahash-wrapped-shash to direct shash. By removing a layer of indirection this both improves performance and reduces