RE: [PATCH v6 1/1] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-13 Thread David Laight
From: Chris von Recklinghausen > Sent: 12 April 2021 20:51 ... > > This is not about BIOS bugs. Hibernation is deep suspend/resume > > grafted onto cold boot, and it is perfectly legal for the firmware to > > present a different memory map to the OS after a cold boot. It is > > Linux that decides t

Re: [PATCH v6 1/1] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-12 Thread Simo Sorce
On Mon, 2021-04-12 at 22:29 +0200, Ard Biesheuvel wrote: > On Mon, 12 Apr 2021 at 21:51, Chris von Recklinghausen > wrote: > > On 4/12/21 3:27 PM, Ard Biesheuvel wrote: > > > On Mon, 12 Apr 2021 at 21:20, Eric Biggers wrote: > > > > On Mon, Apr 12, 2021 at 03:04:58PM -0400, Chris von Recklinghaus

Re: [PATCH v6 1/1] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-12 Thread Ard Biesheuvel
On Mon, 12 Apr 2021 at 21:51, Chris von Recklinghausen wrote: > > On 4/12/21 3:27 PM, Ard Biesheuvel wrote: > > On Mon, 12 Apr 2021 at 21:20, Eric Biggers wrote: > >> On Mon, Apr 12, 2021 at 03:04:58PM -0400, Chris von Recklinghausen wrote: > >>> On 4/12/21 1:45 PM, Eric Biggers wrote: > On

Re: [PATCH v6 1/1] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-12 Thread Chris von Recklinghausen
On 4/12/21 3:27 PM, Ard Biesheuvel wrote: On Mon, 12 Apr 2021 at 21:20, Eric Biggers wrote: On Mon, Apr 12, 2021 at 03:04:58PM -0400, Chris von Recklinghausen wrote: On 4/12/21 1:45 PM, Eric Biggers wrote: On Mon, Apr 12, 2021 at 10:09:32AM -0400, Chris von Recklinghausen wrote: Suspend fail

Re: [PATCH v6 1/1] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-12 Thread Ard Biesheuvel
On Mon, 12 Apr 2021 at 21:20, Eric Biggers wrote: > > On Mon, Apr 12, 2021 at 03:04:58PM -0400, Chris von Recklinghausen wrote: > > On 4/12/21 1:45 PM, Eric Biggers wrote: > > > On Mon, Apr 12, 2021 at 10:09:32AM -0400, Chris von Recklinghausen wrote: > > > > Suspend fails on a system in fips mode

Re: [PATCH v6 1/1] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-12 Thread Chris von Recklinghausen
On 4/12/21 3:20 PM, Eric Biggers wrote: On Mon, Apr 12, 2021 at 03:04:58PM -0400, Chris von Recklinghausen wrote: On 4/12/21 1:45 PM, Eric Biggers wrote: On Mon, Apr 12, 2021 at 10:09:32AM -0400, Chris von Recklinghausen wrote: Suspend fails on a system in fips mode because md5 is used for the

Re: [PATCH v6 1/1] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-12 Thread Eric Biggers
On Mon, Apr 12, 2021 at 03:04:58PM -0400, Chris von Recklinghausen wrote: > On 4/12/21 1:45 PM, Eric Biggers wrote: > > On Mon, Apr 12, 2021 at 10:09:32AM -0400, Chris von Recklinghausen wrote: > > > Suspend fails on a system in fips mode because md5 is used for the e820 > > > integrity check and i

Re: [PATCH v6 1/1] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-12 Thread Chris von Recklinghausen
On 4/12/21 1:45 PM, Eric Biggers wrote: On Mon, Apr 12, 2021 at 10:09:32AM -0400, Chris von Recklinghausen wrote: Suspend fails on a system in fips mode because md5 is used for the e820 integrity check and is not available. Use crc32 instead. This patch changes the integrity check algorithm fro

Re: [PATCH v6 1/1] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-12 Thread Eric Biggers
On Mon, Apr 12, 2021 at 10:09:32AM -0400, Chris von Recklinghausen wrote: > Suspend fails on a system in fips mode because md5 is used for the e820 > integrity check and is not available. Use crc32 instead. > > This patch changes the integrity check algorithm from md5 to crc32. > > The purpose of

[PATCH v6 1/1] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-12 Thread Chris von Recklinghausen
Suspend fails on a system in fips mode because md5 is used for the e820 integrity check and is not available. Use crc32 instead. This patch changes the integrity check algorithm from md5 to crc32. The purpose of the integrity check is to detect possible differences between the memory map used at