Re: [PATCH v6 05/12] tpm2-sessions: Add full HMAC and encrypt/decrypt session handling

2019-09-24 Thread James Bottomley
On Fri, 2019-09-20 at 17:35 +0300, Jarkko Sakkinen wrote: > On Fri, Sep 20, 2019 at 05:34:00PM +0300, Jarkko Sakkinen wrote: > > On Mon, Sep 09, 2019 at 01:20:57PM +0100, James Bottomley wrote: > > Forgot to ask: what is the new field handles? You mean for the null seed or for the virtual handles

Re: [PATCH v6 05/12] tpm2-sessions: Add full HMAC and encrypt/decrypt session handling

2019-09-20 Thread Jarkko Sakkinen
On Fri, Sep 20, 2019 at 05:34:00PM +0300, Jarkko Sakkinen wrote: > On Mon, Sep 09, 2019 at 01:20:57PM +0100, James Bottomley wrote: Forgot to ask: what is the new field handles? /Jarkko

Re: [PATCH v6 05/12] tpm2-sessions: Add full HMAC and encrypt/decrypt session handling

2019-09-20 Thread Jarkko Sakkinen
On Mon, Sep 09, 2019 at 01:20:57PM +0100, James Bottomley wrote: > This code adds true session based HMAC authentication plus parameter > decryption and response encryption using AES. > > The basic design of this code is to segregate all the nasty crypto, > hash and hmac code into tpm2-sessions.c

[PATCH v6 05/12] tpm2-sessions: Add full HMAC and encrypt/decrypt session handling

2019-09-09 Thread James Bottomley
This code adds true session based HMAC authentication plus parameter decryption and response encryption using AES. The basic design of this code is to segregate all the nasty crypto, hash and hmac code into tpm2-sessions.c and export a usable API. The API first of all starts off by gaining a sess