Re: [PATCH v4 2/3] drivers: crypto: Add the Virtual Function driver for CPT

2017-01-12 Thread George Cherian
Hi Stephan, Thank you for the clarification. Regards, -George On 01/12/2017 04:49 PM, Stephan Müller wrote: Am Donnerstag, 12. Januar 2017, 16:40:32 CET schrieb George Cherian: Hi George, Sure, please do not forget to invoke xts_verify_key. Should I be using xts_check_key or xts_verify_k

Re: [PATCH v4 2/3] drivers: crypto: Add the Virtual Function driver for CPT

2017-01-12 Thread Stephan Müller
Am Donnerstag, 12. Januar 2017, 16:40:32 CET schrieb George Cherian: Hi George, > > > > Sure, please do not forget to invoke xts_verify_key. > > Should I be using xts_check_key or xts_verify_key? Both are identical except for the input parameter -- the one requires crypto_skcipher, the other

Re: [PATCH v4 2/3] drivers: crypto: Add the Virtual Function driver for CPT

2017-01-12 Thread George Cherian
Hi Stephan, On 01/11/2017 06:09 PM, Stephan Müller wrote: Am Mittwoch, 11. Januar 2017, 16:58:17 CET schrieb George Cherian: Hi George, I will add a seperate function for xts setkey and make changes as following. ... + +struct crypto_alg algs[] = { { + .cra_flags = CRYPTO_ALG_TYPE_AB

Re: [PATCH v4 2/3] drivers: crypto: Add the Virtual Function driver for CPT

2017-01-11 Thread Stephan Müller
Am Mittwoch, 11. Januar 2017, 16:58:17 CET schrieb George Cherian: Hi George, > I will add a seperate function for xts setkey and make changes as following. > > ... > > > >> + > >> +struct crypto_alg algs[] = { { > >> + .cra_flags = CRYPTO_ALG_TYPE_ABLKCIPHER | CRYPTO_ALG_ASYNC, > >> + .cra_bl

Re: [PATCH v4 2/3] drivers: crypto: Add the Virtual Function driver for CPT

2017-01-11 Thread George Cherian
Hi Stephan, Thanks for pointing it out!! On 01/11/2017 04:42 PM, Stephan Müller wrote: Am Mittwoch, 11. Januar 2017, 10:56:50 CET schrieb George Cherian: Hi George, +int cvm_enc_dec_setkey(struct crypto_ablkcipher *cipher, const u8 *key, + u32 keylen) +{ + struct

Re: [PATCH v4 2/3] drivers: crypto: Add the Virtual Function driver for CPT

2017-01-11 Thread Stephan Müller
Am Mittwoch, 11. Januar 2017, 10:56:50 CET schrieb George Cherian: Hi George, > +int cvm_enc_dec_setkey(struct crypto_ablkcipher *cipher, const u8 *key, > +u32 keylen) > +{ > + struct crypto_tfm *tfm = crypto_ablkcipher_tfm(cipher); > + struct cvm_enc_ctx *ctx = crypto

[PATCH v4 2/3] drivers: crypto: Add the Virtual Function driver for CPT

2017-01-11 Thread George Cherian
Enable the CPT VF driver. CPT is the cryptographic Acceleration Unit in Octeon-tx series of processors. Signed-off-by: George Cherian Reviewed-by: David Daney --- drivers/crypto/cavium/cpt/Makefile | 3 +- drivers/crypto/cavium/cpt/cptvf.h| 135 drivers/crypto/caviu