Re: [PATCH v4 1/5] crypto: add blake2b generic implementation

2019-10-13 Thread David Sterba
On Fri, Oct 11, 2019 at 11:04:40AM -0700, Eric Biggers wrote: > > +struct blake2b_param > > +{ > > It should be 'struct blake2b_param {' > > checkpatch.pl should warn about this. Can you fix the checkpatch warnings > that > make sense to fix? I fixed all the { at the end of line of struct defi

Re: [PATCH v4 1/5] crypto: add blake2b generic implementation

2019-10-11 Thread Eric Biggers
On Fri, Oct 11, 2019 at 06:52:04PM +0200, David Sterba wrote: > The patch brings support of several BLAKE2 variants (2b with various > digest lengths). The keyed digest is supported, using tfm->setkey call. > The in-tree user will be btrfs (for checksumming), we're going to use > the BLAKE2b-256 v

Re: [PATCH v4 1/5] crypto: add blake2b generic implementation

2019-10-11 Thread Eric Biggers
On Fri, Oct 11, 2019 at 06:52:04PM +0200, David Sterba wrote: > diff --git a/crypto/Makefile b/crypto/Makefile > index 9479e1a45d8c..2318420d3e71 100644 > --- a/crypto/Makefile > +++ b/crypto/Makefile > @@ -74,6 +74,7 @@ obj-$(CONFIG_CRYPTO_STREEBOG) += streebog_generic.o > obj-$(CONFIG_CRYPTO_WP5

[PATCH v4 1/5] crypto: add blake2b generic implementation

2019-10-11 Thread David Sterba
The patch brings support of several BLAKE2 variants (2b with various digest lengths). The keyed digest is supported, using tfm->setkey call. The in-tree user will be btrfs (for checksumming), we're going to use the BLAKE2b-256 variant. The code is reference implementation taken from the official