Re: [PATCH v4 02/35] crypto: chacha - move existing library code into lib/crypto

2019-10-22 Thread Eric Biggers
On Thu, Oct 17, 2019 at 09:08:59PM +0200, Ard Biesheuvel wrote: > diff --git a/lib/crypto/libchacha.c b/lib/crypto/libchacha.c > new file mode 100644 > index ..7b4b97811f71 > --- /dev/null > +++ b/lib/crypto/libchacha.c > @@ -0,0 +1,35 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later

Re: [PATCH v4 02/35] crypto: chacha - move existing library code into lib/crypto

2019-10-22 Thread Eric Biggers
On Thu, Oct 17, 2019 at 09:08:59PM +0200, Ard Biesheuvel wrote: > +static inline void chacha_crypt(u32 *state, u8 *dst, const u8 *src, > + unsigned int bytes, int nrounds) > +{ > + if (IS_ENABLED(CONFIG_CRYPTO_ARCH_HAVE_LIB_CHACHA)) > + chacha_crypt_arch(

[PATCH v4 02/35] crypto: chacha - move existing library code into lib/crypto

2019-10-17 Thread Ard Biesheuvel
Currently, our generic ChaCha implementation consists of a permute function in lib/chacha.c that operates on the 64-byte ChaCha state directly [and which is always included into the core kernel since it is used by the /dev/random driver], and the crypto API plumbing to expose it as a skcipher. In