Re: [PATCH v3 21/29] crypto: BLAKE2s - generic C library implementation and selftest

2019-10-14 Thread Ard Biesheuvel
On Fri, 11 Oct 2019 at 18:46, Jason A. Donenfeld wrote: > > On Thu, Oct 10, 2019 at 11:02:32PM -0700, Eric Biggers wrote: > > FYI, I had left a few review comments on Jason's last version of this patch > > (https://lkml.kernel.org/linux-crypto/20190326173759.GA607@zzz.localdomain/), > > some of wh

Re: [PATCH v3 21/29] crypto: BLAKE2s - generic C library implementation and selftest

2019-10-11 Thread Jason A. Donenfeld
On Thu, Oct 10, 2019 at 11:02:32PM -0700, Eric Biggers wrote: > FYI, I had left a few review comments on Jason's last version of this patch > (https://lkml.kernel.org/linux-crypto/20190326173759.GA607@zzz.localdomain/), > some of which Jason addressed in the Wireguard repository > (https://git.zx2c

Re: [PATCH v3 21/29] crypto: BLAKE2s - generic C library implementation and selftest

2019-10-10 Thread Eric Biggers
On Mon, Oct 07, 2019 at 06:46:02PM +0200, Ard Biesheuvel wrote: > From: "Jason A. Donenfeld" > > The C implementation was originally based on Samuel Neves' public > domain reference implementation but has since been heavily modified > for the kernel. We're able to do compile-time optimizations by

[PATCH v3 21/29] crypto: BLAKE2s - generic C library implementation and selftest

2019-10-07 Thread Ard Biesheuvel
From: "Jason A. Donenfeld" The C implementation was originally based on Samuel Neves' public domain reference implementation but has since been heavily modified for the kernel. We're able to do compile-time optimizations by moving some scaffolding around the final function into the header file.