Re: [PATCH v3 2/8] crypto: add driver-side scomp interface

2016-03-23 Thread Herbert Xu
On Fri, Mar 18, 2016 at 02:02:49PM +, Giovanni Cabiddu wrote: > > Are you suggesting to add to the struct acomp_req a pointer to a vmalloc > area and remove the request context (which is contiguous to acomp_req and > allocated in request_alloc)? What I'm suggesting is simply to generalise the

Re: [PATCH v3 2/8] crypto: add driver-side scomp interface

2016-03-19 Thread Giovanni Cabiddu
Hi Herbert, I would like to have some clarifications before submitting a v4. On Thu, Mar 17, 2016 at 07:00:27PM +0800, Herbert Xu wrote: > On Wed, Feb 24, 2016 at 05:51:44PM +, Giovanni Cabiddu wrote: > > > > +#define CRYPTO_SCOMP_DECOMP_NOCTX CRYPTO_ALG_PRIVATE > > I don't think this should

Re: [PATCH v3 2/8] crypto: add driver-side scomp interface

2016-03-19 Thread Herbert Xu
On Wed, Feb 24, 2016 at 05:51:44PM +, Giovanni Cabiddu wrote: > > +#define CRYPTO_SCOMP_DECOMP_NOCTX CRYPTO_ALG_PRIVATE I don't think this should be an scomp-specific flag. The point of noctx is that we don't need to do a request-specific vmalloc. Chances are that with hardware offload that y

[PATCH v3 2/8] crypto: add driver-side scomp interface

2016-02-24 Thread Giovanni Cabiddu
Add a synchronous back-end (scomp) to acomp. This allows to easily expose the already present compression algorithms in LKCF via acomp. Signed-off-by: Giovanni Cabiddu --- crypto/Makefile |1 + crypto/acompress.c | 75 ++- crypto/scompress.c