Re: [PATCH v3 1/3] crypto: rsa - generalize ASN.1 sequences

2016-04-24 Thread Herbert Xu
On Mon, Apr 25, 2016 at 05:54:44AM +, Tudor-Dan Ambarus wrote: > > Do you want me to address some suggestions, or do you intend to apply this > patch set? Please ensure that we have exactly one parser for the RSA keys. It should just return the raw integer with no other processing. The softw

RE: [PATCH v3 1/3] crypto: rsa - generalize ASN.1 sequences

2016-04-24 Thread Tudor-Dan Ambarus
Hi Herbert, > > On Fri, Apr 15, 2016 at 02:32:42PM +, Tudor-Dan Ambarus wrote: > > > > On Wed, Apr 06, 2016 at 04:37:04PM +0300, Tudor Ambarus wrote: > > > > > This approach has the advantage that users can select specific > > > > > parser actions by using a general parser with function pointe

RE: [PATCH v3 1/3] crypto: rsa - generalize ASN.1 sequences

2016-04-15 Thread Tudor-Dan Ambarus
> On Fri, Apr 15, 2016 at 02:32:42PM +, Tudor-Dan Ambarus wrote: > > > On Wed, Apr 06, 2016 at 04:37:04PM +0300, Tudor Ambarus wrote: > > > > This approach has the advantage that users can select specific > > > > parser actions by using a general parser with function pointers > > > > to specifi

Re: [PATCH v3 1/3] crypto: rsa - generalize ASN.1 sequences

2016-04-15 Thread Herbert Xu
On Fri, Apr 15, 2016 at 02:32:42PM +, Tudor-Dan Ambarus wrote: > > On Wed, Apr 06, 2016 at 04:37:04PM +0300, Tudor Ambarus wrote: > > > This approach has the advantage that users can select specific > > > parser actions by using a general parser with function pointers > > > to specific actions.

RE: [PATCH v3 1/3] crypto: rsa - generalize ASN.1 sequences

2016-04-15 Thread Tudor-Dan Ambarus
> On Wed, Apr 06, 2016 at 04:37:04PM +0300, Tudor Ambarus wrote: > > This approach has the advantage that users can select specific > > parser actions by using a general parser with function pointers > > to specific actions. > > I don't understand why we need different parsing functions in the > f

Re: [PATCH v3 1/3] crypto: rsa - generalize ASN.1 sequences

2016-04-15 Thread Herbert Xu
On Wed, Apr 06, 2016 at 04:37:04PM +0300, Tudor Ambarus wrote: > Use common ASN.1 sequences for all RSA implementations. > > Give hardware RSA implementations the chance to use > the RSA's software implementation parser even if they > are likely to want to use raw integers. > > The parser expects

[PATCH v3 1/3] crypto: rsa - generalize ASN.1 sequences

2016-04-06 Thread Tudor Ambarus
Use common ASN.1 sequences for all RSA implementations. Give hardware RSA implementations the chance to use the RSA's software implementation parser even if they are likely to want to use raw integers. The parser expects a context that contains at the first address a pointer to a struct rsa_asn1_