Re: [PATCH v3 07/29] crypto: arm/chacha - remove dependency on generic ChaCha driver

2019-10-10 Thread Eric Biggers
On Mon, Oct 07, 2019 at 06:45:48PM +0200, Ard Biesheuvel wrote: > +static int chacha_stream_xor(struct skcipher_request *req, > + const struct chacha_ctx *ctx, const u8 *iv) > +{ > + struct skcipher_walk walk; > + u32 state[16]; > + int err; > + > + err = sk

Re: [PATCH v3 07/29] crypto: arm/chacha - remove dependency on generic ChaCha driver

2019-10-10 Thread Eric Biggers
On Mon, Oct 07, 2019 at 06:45:48PM +0200, Ard Biesheuvel wrote: > diff --git a/arch/arm/crypto/chacha-scalar-core.S > b/arch/arm/crypto/chacha-scalar-core.S > index 2140319b64a0..0970ae107590 100644 > --- a/arch/arm/crypto/chacha-scalar-core.S > +++ b/arch/arm/crypto/chacha-scalar-core.S > @@ -41,

[PATCH v3 07/29] crypto: arm/chacha - remove dependency on generic ChaCha driver

2019-10-07 Thread Ard Biesheuvel
Instead of falling back to the generic ChaCha skcipher driver for non-SIMD cases, use a fast scalar implementation for ARM authored by Eric Biggers. This removes the module dependency on chacha-generic altogether, which also simplifies things when we expose the ChaCha library interface from this mo