Re: [PATCH v3] crypto: prefix module autoloading with "crypto-"

2014-11-24 Thread Herbert Xu
On Thu, Nov 20, 2014 at 05:05:53PM -0800, Kees Cook wrote: > This prefixes all crypto module loading with "crypto-" so we never run > the risk of exposing module auto-loading to userspace via a crypto API, > as demonstrated by Mathias Krause: > > https://lkml.org/lkml/2013/3/4/70 > > Signed-off-b

Re: [PATCH v3] crypto: prefix module autoloading with "crypto-"

2014-11-21 Thread Herbert Xu
On Fri, Nov 21, 2014 at 09:31:15AM +0100, Mathias Krause wrote: > > The last modlog call does not contain the "crypto-" prefix, therefore > happily loads the vfat module. > I guess crypto templates are handled special? Yes templates are loaded in crypto_lookup_template so a small change there (ass

Re: [PATCH v3] crypto: prefix module autoloading with "crypto-"

2014-11-21 Thread Mathias Krause
On 21 November 2014 02:05, Kees Cook wrote: > This prefixes all crypto module loading with "crypto-" so we never run > the risk of exposing module auto-loading to userspace via a crypto API, > as demonstrated by Mathias Krause: > > https://lkml.org/lkml/2013/3/4/70 > > Signed-off-by: Kees Cook >

[PATCH v3] crypto: prefix module autoloading with "crypto-"

2014-11-20 Thread Kees Cook
This prefixes all crypto module loading with "crypto-" so we never run the risk of exposing module auto-loading to userspace via a crypto API, as demonstrated by Mathias Krause: https://lkml.org/lkml/2013/3/4/70 Signed-off-by: Kees Cook --- v3: - added unprefixed alias back for userspace compat