Re: [PATCH v2 05/20] crypto: mips/chacha - import accelerated 32r2 code from Zinc

2019-10-06 Thread René van Dorst
Quoting Ard Biesheuvel : Hi Ard, Thanks a lot for taking the time to double check this. I think it would be nice to be able to expose xchacha12 like we do on other architectures. Note that for xchacha, I also added a hchacha_block() routine based on your code (with the round count as the thi

Re: [PATCH v2 05/20] crypto: mips/chacha - import accelerated 32r2 code from Zinc

2019-10-05 Thread René van Dorst
Hi Ard and Jason, Quoting Ard Biesheuvel : On Fri, 4 Oct 2019 at 17:15, René van Dorst wrote: Hi Jason, Quoting "Jason A. Donenfeld" : > On Fri, Oct 4, 2019 at 4:44 PM Ard Biesheuvel > wrote: >> The round count is passed via the fifth function parameter, so it is >> already on the stack.

Re: [PATCH v2 05/20] crypto: mips/chacha - import accelerated 32r2 code from Zinc

2019-10-04 Thread Ard Biesheuvel
On Fri, 4 Oct 2019 at 17:15, René van Dorst wrote: > > Hi Jason, > > Quoting "Jason A. Donenfeld" : > > > On Fri, Oct 4, 2019 at 4:44 PM Ard Biesheuvel > > wrote: > >> The round count is passed via the fifth function parameter, so it is > >> already on the stack. Reloading it for every block does

Re: [PATCH v2 05/20] crypto: mips/chacha - import accelerated 32r2 code from Zinc

2019-10-04 Thread René van Dorst
Hi Jason, Quoting "Jason A. Donenfeld" : On Fri, Oct 4, 2019 at 4:44 PM Ard Biesheuvel wrote: The round count is passed via the fifth function parameter, so it is already on the stack. Reloading it for every block doesn't sound like a huge deal to me. Please benchmark it to indicate that,

Re: [PATCH v2 05/20] crypto: mips/chacha - import accelerated 32r2 code from Zinc

2019-10-04 Thread Ard Biesheuvel
On Fri, 4 Oct 2019 at 16:59, Jason A. Donenfeld wrote: > > On Fri, Oct 4, 2019 at 4:44 PM Ard Biesheuvel > wrote: > > The round count is passed via the fifth function parameter, so it is > > already on the stack. Reloading it for every block doesn't sound like > > a huge deal to me. > > Please b

Re: [PATCH v2 05/20] crypto: mips/chacha - import accelerated 32r2 code from Zinc

2019-10-04 Thread Jason A. Donenfeld
On Fri, Oct 4, 2019 at 4:44 PM Ard Biesheuvel wrote: > The round count is passed via the fifth function parameter, so it is > already on the stack. Reloading it for every block doesn't sound like > a huge deal to me. Please benchmark it to indicate that, if it really isn't a big deal. I recall fi

Re: [PATCH v2 05/20] crypto: mips/chacha - import accelerated 32r2 code from Zinc

2019-10-04 Thread Ard Biesheuvel
On Fri, 4 Oct 2019 at 16:38, Ard Biesheuvel wrote: > > On Fri, 4 Oct 2019 at 15:46, Jason A. Donenfeld wrote: > > > > On Wed, Oct 02, 2019 at 04:16:58PM +0200, Ard Biesheuvel wrote: > > > This integrates the accelerated MIPS 32r2 implementation of ChaCha > > > into both the API and library interf

Re: [PATCH v2 05/20] crypto: mips/chacha - import accelerated 32r2 code from Zinc

2019-10-04 Thread Ard Biesheuvel
On Fri, 4 Oct 2019 at 15:46, Jason A. Donenfeld wrote: > > On Wed, Oct 02, 2019 at 04:16:58PM +0200, Ard Biesheuvel wrote: > > This integrates the accelerated MIPS 32r2 implementation of ChaCha > > into both the API and library interfaces of the kernel crypto stack. > > > > The significance of thi

Re: [PATCH v2 05/20] crypto: mips/chacha - import accelerated 32r2 code from Zinc

2019-10-04 Thread Jason A. Donenfeld
On Wed, Oct 02, 2019 at 04:16:58PM +0200, Ard Biesheuvel wrote: > This integrates the accelerated MIPS 32r2 implementation of ChaCha > into both the API and library interfaces of the kernel crypto stack. > > The significance of this is that, in addition to becoming available > as an accelerated li

[PATCH v2 05/20] crypto: mips/chacha - import accelerated 32r2 code from Zinc

2019-10-02 Thread Ard Biesheuvel
This integrates the accelerated MIPS 32r2 implementation of ChaCha into both the API and library interfaces of the kernel crypto stack. The significance of this is that, in addition to becoming available as an accelerated library implementation, it can also be used by existing crypto API code such