Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support

2016-02-04 Thread Joonsoo Kim
2016-02-04 23:53 GMT+09:00 Herbert Xu : > On Thu, Feb 04, 2016 at 04:17:41PM +0900, Joonsoo Kim wrote: >> >> Do you think not to merge scomp? Please let me know your overall >> plan about this.? > > I'm fine with a driver-side scomp interface. But I'd rather > avoid having yet another user-side co

Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support

2016-02-04 Thread Herbert Xu
On Thu, Feb 04, 2016 at 11:50:46AM +0800, Li, Weigang wrote: > > Seems I need go back to my first acomp patch.. Assuming we shall > still keep the comp i/f, and the linearisation of sg-list in acomp > to fit the "comp" API? What do you mean by the driver-side scomp? What I mean is that the bottom

Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support

2016-02-04 Thread Herbert Xu
On Thu, Feb 04, 2016 at 04:17:41PM +0900, Joonsoo Kim wrote: > > Do you think not to merge scomp? Please let me know your overall > plan about this.? I'm fine with a driver-side scomp interface. But I'd rather avoid having yet another user-side compression interface in the form of scomp if we can

Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support

2016-02-03 Thread Joonsoo Kim
2016-02-04 12:28 GMT+09:00 Herbert Xu : > On Thu, Feb 04, 2016 at 11:25:27AM +0800, Li, Weigang wrote: >> >> Please can you advise how to get the acomp patch accepted? > > Can you do a posting of these patches without scomp so we can > evaluate the effects? > Do you think not to merge scomp? Pleas

Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support

2016-02-03 Thread Li, Weigang
On 2/4/2016 11:29 AM, Herbert Xu wrote: On Thu, Feb 04, 2016 at 11:28:50AM +0800, Herbert Xu wrote: On Thu, Feb 04, 2016 at 11:25:27AM +0800, Li, Weigang wrote: Please can you advise how to get the acomp patch accepted? Can you do a posting of these patches without scomp so we can evaluate t

Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support

2016-02-03 Thread Herbert Xu
On Thu, Feb 04, 2016 at 11:28:50AM +0800, Herbert Xu wrote: > On Thu, Feb 04, 2016 at 11:25:27AM +0800, Li, Weigang wrote: > > > > Please can you advise how to get the acomp patch accepted? > > Can you do a posting of these patches without scomp so we can > evaluate the effects? Of course you can

Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support

2016-02-03 Thread Herbert Xu
On Thu, Feb 04, 2016 at 11:25:27AM +0800, Li, Weigang wrote: > > Please can you advise how to get the acomp patch accepted? Can you do a posting of these patches without scomp so we can evaluate the effects? Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: h

Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support

2016-02-03 Thread Li, Weigang
On 2/1/2016 10:11 AM, Joonsoo Kim wrote: On Fri, Jan 29, 2016 at 06:09:01PM +0800, Herbert Xu wrote: On Thu, Jan 28, 2016 at 12:19:42PM +0900, Joonsoo Kim wrote: I have tested asynchronous compression APIs in zram and I saw regression. Atomic allocation and setting up SG lists are culprit for

Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support

2016-01-31 Thread Joonsoo Kim
On Fri, Jan 29, 2016 at 06:09:01PM +0800, Herbert Xu wrote: > On Thu, Jan 28, 2016 at 12:19:42PM +0900, Joonsoo Kim wrote: > > > > I have tested asynchronous compression APIs in zram and I saw > > regression. Atomic allocation and setting up SG lists are culprit > > for this regression. Moreover, z

Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support

2016-01-29 Thread Herbert Xu
On Thu, Jan 28, 2016 at 12:19:42PM +0900, Joonsoo Kim wrote: > > I have tested asynchronous compression APIs in zram and I saw > regression. Atomic allocation and setting up SG lists are culprit > for this regression. Moreover, zram optimizes linearisation So which is it, atomic allocations or set

Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support

2016-01-27 Thread Joonsoo Kim
Hello, Herbert. On Wed, Jan 27, 2016 at 04:09:26PM +0800, Herbert Xu wrote: > On Wed, Jan 27, 2016 at 04:03:55PM +0800, Herbert Xu wrote: > > On Wed, Jan 27, 2016 at 03:59:05PM +0800, Li, Weigang wrote: > > > > > > The acomp is also SG-based, while scomp only accepts flat buffer. > > > > Right, b

Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support

2016-01-27 Thread Li, Weigang
On 1/27/2016 4:09 PM, Herbert Xu wrote: On Wed, Jan 27, 2016 at 04:03:55PM +0800, Herbert Xu wrote: On Wed, Jan 27, 2016 at 03:59:05PM +0800, Li, Weigang wrote: The acomp is also SG-based, while scomp only accepts flat buffer. Right, but do we need a pointer-based scomp at all? IPComp would

Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support

2016-01-27 Thread Herbert Xu
On Wed, Jan 27, 2016 at 04:03:55PM +0800, Herbert Xu wrote: > On Wed, Jan 27, 2016 at 03:59:05PM +0800, Li, Weigang wrote: > > > > The acomp is also SG-based, while scomp only accepts flat buffer. > > Right, but do we need a pointer-based scomp at all? IPComp would > certainly be better off with a

Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support

2016-01-27 Thread Herbert Xu
On Wed, Jan 27, 2016 at 03:59:05PM +0800, Li, Weigang wrote: > > The acomp is also SG-based, while scomp only accepts flat buffer. Right, but do we need a pointer-based scomp at all? IPComp would certainly be better off with an SG-based interface. Any other users of compression are presumably dea

Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support

2016-01-26 Thread Li, Weigang
On 1/27/2016 3:41 PM, Herbert Xu wrote: On Tue, Jan 26, 2016 at 05:15:06PM +0900, Joonsoo Kim wrote: From: Weigang Li Now, asynchronous compression APIs are supported. There is no asynchronous compression driver now but this APIs can be used as front-end to synchronous compression algorithm. I

Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support

2016-01-26 Thread Herbert Xu
On Tue, Jan 26, 2016 at 05:15:06PM +0900, Joonsoo Kim wrote: > From: Weigang Li > > Now, asynchronous compression APIs are supported. There is no asynchronous > compression driver now but this APIs can be used as front-end to > synchronous compression algorithm. In this case, scatterlist would be

[PATCH v2 04/10] crypto/compress: add asynchronous compression support

2016-01-26 Thread Joonsoo Kim
From: Weigang Li Now, asynchronous compression APIs are supported. There is no asynchronous compression driver now but this APIs can be used as front-end to synchronous compression algorithm. In this case, scatterlist would be linearlized when needed so it would cause some overhead. Signed-off-b