Re: [PATCH v2 02/11] crypto: Add Allwinner sun8i-ce Crypto Engine

2019-10-04 Thread Corentin Labbe
On Wed, Oct 02, 2019 at 12:35:06PM +0200, Maxime Ripard wrote: > Hi, > > On Tue, Oct 01, 2019 at 08:41:32PM +0200, Corentin Labbe wrote: > > + /* CTS and recent CE (H6) need length in bytes, in word otherwise */ > > + if (ce->variant->model == CE_v2) > > + cet->t_dlen = areq->cryptle

Re: [PATCH v2 02/11] crypto: Add Allwinner sun8i-ce Crypto Engine

2019-10-02 Thread Maxime Ripard
Hi, On Tue, Oct 01, 2019 at 08:41:32PM +0200, Corentin Labbe wrote: > + /* CTS and recent CE (H6) need length in bytes, in word otherwise */ > + if (ce->variant->model == CE_v2) > + cet->t_dlen = areq->cryptlen; It's entirely redundant withe the compatible. How about using so

[PATCH v2 02/11] crypto: Add Allwinner sun8i-ce Crypto Engine

2019-10-01 Thread Corentin Labbe
The Crypto Engine is an hardware cryptographic offloader present on all recent Allwinner SoCs H2+, H3, R40, A64, H5, H6 This driver supports AES cipher in CBC/ECB mode. Signed-off-by: Corentin Labbe --- drivers/crypto/allwinner/Kconfig | 27 + drivers/crypto/allwinner/Makefile