Re: [PATCH v2 00/20] crypto: crypto API library interfaces for WireGuard

2019-10-07 Thread Andy Lutomirski
On Mon, Oct 7, 2019 at 8:12 AM Ard Biesheuvel wrote: > > On Mon, 7 Oct 2019 at 17:02, Andy Lutomirski wrote: > > > > On Sun, Oct 6, 2019 at 10:24 PM Ard Biesheuvel > > wrote: > > > > > > On Mon, 7 Oct 2019 at 06:44, Andy Lutomirski wrote: > > > > > > > > > > > Actually, this can be addressed by

Re: [PATCH v2 00/20] crypto: crypto API library interfaces for WireGuard

2019-10-07 Thread Ard Biesheuvel
On Mon, 7 Oct 2019 at 17:02, Andy Lutomirski wrote: > > On Sun, Oct 6, 2019 at 10:24 PM Ard Biesheuvel > wrote: > > > > On Mon, 7 Oct 2019 at 06:44, Andy Lutomirski wrote: > > > > > > > > Actually, this can be addressed by retaining the module dependencies > > > > as before, but permitting the a

Re: [PATCH v2 00/20] crypto: crypto API library interfaces for WireGuard

2019-10-07 Thread Andy Lutomirski
On Sun, Oct 6, 2019 at 10:24 PM Ard Biesheuvel wrote: > > On Mon, 7 Oct 2019 at 06:44, Andy Lutomirski wrote: > > > > > Actually, this can be addressed by retaining the module dependencies > > > as before, but permitting the arch module to be omitted at load time. > > > > I think that, to avoid

Re: [PATCH v2 00/20] crypto: crypto API library interfaces for WireGuard

2019-10-06 Thread Ard Biesheuvel
On Mon, 7 Oct 2019 at 06:44, Andy Lutomirski wrote: > > > > > On Oct 5, 2019, at 12:24 AM, Ard Biesheuvel > > wrote: > > > > On Fri, 4 Oct 2019 at 16:56, Ard Biesheuvel > > wrote: > >> > >>> On Fri, 4 Oct 2019 at 16:53, Andy Lutomirski wrote: > >>> > >>> > >>> > On Oct 4, 2019, at 6:52

Re: [PATCH v2 00/20] crypto: crypto API library interfaces for WireGuard

2019-10-06 Thread Andy Lutomirski
> On Oct 5, 2019, at 12:24 AM, Ard Biesheuvel wrote: > > On Fri, 4 Oct 2019 at 16:56, Ard Biesheuvel > wrote: >> >>> On Fri, 4 Oct 2019 at 16:53, Andy Lutomirski wrote: >>> >>> >>> On Oct 4, 2019, at 6:52 AM, Ard Biesheuvel wrote: On Fri, 4 Oct 2019 at 15:42, Ja

Re: [PATCH v2 00/20] crypto: crypto API library interfaces for WireGuard

2019-10-05 Thread Ard Biesheuvel
On Fri, 4 Oct 2019 at 16:56, Ard Biesheuvel wrote: > > On Fri, 4 Oct 2019 at 16:53, Andy Lutomirski wrote: > > > > > > > > > On Oct 4, 2019, at 6:52 AM, Ard Biesheuvel > > > wrote: > > > > > > On Fri, 4 Oct 2019 at 15:42, Jason A. Donenfeld wrote: > > >> > > >>> On Thu, Oct 03, 2019 at 10:43:

Re: [PATCH v2 00/20] crypto: crypto API library interfaces for WireGuard

2019-10-04 Thread Ard Biesheuvel
On Fri, 4 Oct 2019 at 16:55, Jason A. Donenfeld wrote: > > On Fri, Oct 4, 2019 at 4:53 PM Andy Lutomirski wrote: > > I think it might be better to allow two different modules to export the > > same symbol but only allow one of them to be loaded. Or use static calls. > > Static calls perform well

Re: [PATCH v2 00/20] crypto: crypto API library interfaces for WireGuard

2019-10-04 Thread Ard Biesheuvel
On Fri, 4 Oct 2019 at 16:53, Andy Lutomirski wrote: > > > > > On Oct 4, 2019, at 6:52 AM, Ard Biesheuvel > > wrote: > > > > On Fri, 4 Oct 2019 at 15:42, Jason A. Donenfeld wrote: > >> > >>> On Thu, Oct 03, 2019 at 10:43:29AM +0200, Ard Biesheuvel wrote: > >>> On Wed, 2 Oct 2019 at 16:17, Ard B

Re: [PATCH v2 00/20] crypto: crypto API library interfaces for WireGuard

2019-10-04 Thread Jason A. Donenfeld
On Fri, Oct 4, 2019 at 4:53 PM Andy Lutomirski wrote: > I think it might be better to allow two different modules to export the same > symbol but only allow one of them to be loaded. Or use static calls. Static calls perform well and are well understood. This would be my preference.

Re: [PATCH v2 00/20] crypto: crypto API library interfaces for WireGuard

2019-10-04 Thread Andy Lutomirski
> On Oct 4, 2019, at 6:52 AM, Ard Biesheuvel wrote: > > On Fri, 4 Oct 2019 at 15:42, Jason A. Donenfeld wrote: >> >>> On Thu, Oct 03, 2019 at 10:43:29AM +0200, Ard Biesheuvel wrote: >>> On Wed, 2 Oct 2019 at 16:17, Ard Biesheuvel >>> wrote: >>> ... In the future, I would

Re: [PATCH v2 00/20] crypto: crypto API library interfaces for WireGuard

2019-10-04 Thread Andy Lutomirski
> On Oct 4, 2019, at 6:42 AM, Jason A. Donenfeld wrote: > > On Thu, Oct 03, 2019 at 10:43:29AM +0200, Ard Biesheuvel wrote: >>> On Wed, 2 Oct 2019 at 16:17, Ard Biesheuvel >>> wrote: >>> >> ... >>> >>> In the future, I would like to extend these interfaces to use static calls, >>> so that

Re: [PATCH v2 00/20] crypto: crypto API library interfaces for WireGuard

2019-10-04 Thread Jason A. Donenfeld
On Wed, Oct 2, 2019 at 4:17 PM Ard Biesheuvel wrote: > This is a followup to RFC 'crypto: wireguard with crypto API library > interface' > [0]. Since no objections were raised to my approach, I've proceeded to fix up > some minor issues, and incorporate [most of] the missing MIPS code. Could you

Re: [PATCH v2 00/20] crypto: crypto API library interfaces for WireGuard

2019-10-04 Thread Ard Biesheuvel
On Fri, 4 Oct 2019 at 15:42, Jason A. Donenfeld wrote: > > On Thu, Oct 03, 2019 at 10:43:29AM +0200, Ard Biesheuvel wrote: > > On Wed, 2 Oct 2019 at 16:17, Ard Biesheuvel > > wrote: > > > > > ... > > > > > > In the future, I would like to extend these interfaces to use static > > > calls, > > >

Re: [PATCH v2 00/20] crypto: crypto API library interfaces for WireGuard

2019-10-04 Thread Jason A. Donenfeld
On Thu, Oct 03, 2019 at 10:43:29AM +0200, Ard Biesheuvel wrote: > On Wed, 2 Oct 2019 at 16:17, Ard Biesheuvel wrote: > > > ... > > > > In the future, I would like to extend these interfaces to use static calls, > > so that the accelerated implementations can be [un]plugged at runtime. For > > the

Re: [PATCH v2 00/20] crypto: crypto API library interfaces for WireGuard

2019-10-04 Thread Jason A. Donenfeld
Hi Ard, On Wed, Oct 02, 2019 at 04:16:53PM +0200, Ard Biesheuvel wrote: > This is a followup to RFC 'crypto: wireguard with crypto API library > interface' > [0]. Since no objections were raised to my approach, I've proceeded to fix up > some minor issues, and incorporate [most of] the missing MI

Re: [PATCH v2 00/20] crypto: crypto API library interfaces for WireGuard

2019-10-03 Thread Ard Biesheuvel
On Wed, 2 Oct 2019 at 16:17, Ard Biesheuvel wrote: > ... > > In the future, I would like to extend these interfaces to use static calls, > so that the accelerated implementations can be [un]plugged at runtime. For > the time being, we rely on weak aliases and conditional exports so that the > user

[PATCH v2 00/20] crypto: crypto API library interfaces for WireGuard

2019-10-02 Thread Ard Biesheuvel
This is a followup to RFC 'crypto: wireguard with crypto API library interface' [0]. Since no objections were raised to my approach, I've proceeded to fix up some minor issues, and incorporate [most of] the missing MIPS code. Changes since RFC/v1: - dropped the WireGuard patch itself, and the foll