Re: [PATCH v2 0/7] crypto: fuzz algorithms against their generic implementation

2019-05-02 Thread Horia Geanta
On 4/27/2019 8:03 PM, Eric Biggers wrote: > On Sat, Apr 27, 2019 at 03:24:38PM +, Horia Geanta wrote: >> On 4/26/2019 7:54 PM, Eric Biggers wrote: >>> Hi Horia, >>> >>> On Fri, Apr 26, 2019 at 04:35:05PM +, Horia Geanta wrote: On 4/12/2019 8:00 AM, Eric Biggers wrote: > So far I've

Re: [PATCH v2 0/7] crypto: fuzz algorithms against their generic implementation

2019-04-27 Thread Eric Biggers
On Sat, Apr 27, 2019 at 03:24:38PM +, Horia Geanta wrote: > On 4/26/2019 7:54 PM, Eric Biggers wrote: > > Hi Horia, > > > > On Fri, Apr 26, 2019 at 04:35:05PM +, Horia Geanta wrote: > >> On 4/12/2019 8:00 AM, Eric Biggers wrote: > >>> So far I've tested all generic, x86, arm, and arm64 alg

Re: [PATCH v2 0/7] crypto: fuzz algorithms against their generic implementation

2019-04-27 Thread Horia Geanta
On 4/26/2019 7:54 PM, Eric Biggers wrote: > Hi Horia, > > On Fri, Apr 26, 2019 at 04:35:05PM +, Horia Geanta wrote: >> On 4/12/2019 8:00 AM, Eric Biggers wrote: >>> So far I've tested all generic, x86, arm, and arm64 algorithms, plus >>> some PowerPC algorithms. I have not tested hardware dri

Re: [PATCH v2 0/7] crypto: fuzz algorithms against their generic implementation

2019-04-26 Thread Eric Biggers
Hi Horia, On Fri, Apr 26, 2019 at 04:35:05PM +, Horia Geanta wrote: > On 4/12/2019 8:00 AM, Eric Biggers wrote: > > So far I've tested all generic, x86, arm, and arm64 algorithms, plus > > some PowerPC algorithms. I have not tested hardware drivers. I > > encourage people to run the tests on

Re: [PATCH v2 0/7] crypto: fuzz algorithms against their generic implementation

2019-04-26 Thread Horia Geanta
On 4/12/2019 8:00 AM, Eric Biggers wrote: > So far I've tested all generic, x86, arm, and arm64 algorithms, plus > some PowerPC algorithms. I have not tested hardware drivers. I > encourage people to run the tests on drivers and other architectures, as > they will find more bugs. > I am seeing s

Re: [PATCH v2 0/7] crypto: fuzz algorithms against their generic implementation

2019-04-18 Thread Herbert Xu
On Thu, Apr 11, 2019 at 09:57:35PM -0700, Eric Biggers wrote: > > Eric Biggers (7): > crypto: testmgr - expand ability to test for errors > crypto: testmgr - identify test vectors by name rather than number > crypto: testmgr - add helpers for fuzzing against generic > implementation >

Re: [PATCH v2 0/7] crypto: fuzz algorithms against their generic implementation

2019-04-12 Thread Eric Biggers
On Fri, Apr 12, 2019 at 02:04:20PM -0700, Ard Biesheuvel wrote: > On Thu, 11 Apr 2019 at 22:00, Eric Biggers wrote: > > > > Hello, > > > > In the crypto API, all implementations of each algorithm are supposed to > > produce the same results. However, testing of this is currently limited > > to th

Re: [PATCH v2 0/7] crypto: fuzz algorithms against their generic implementation

2019-04-12 Thread Ard Biesheuvel
On Thu, 11 Apr 2019 at 22:00, Eric Biggers wrote: > > Hello, > > In the crypto API, all implementations of each algorithm are supposed to > produce the same results. However, testing of this is currently limited > to the list of test vectors hardcoded for each algorithm. Although > after recent

[PATCH v2 0/7] crypto: fuzz algorithms against their generic implementation

2019-04-11 Thread Eric Biggers
Hello, In the crypto API, all implementations of each algorithm are supposed to produce the same results. However, testing of this is currently limited to the list of test vectors hardcoded for each algorithm. Although after recent improvements the self-tests do much more with each test vector,