Re: [PATCH v2 0/3] ARM: NEON based fast(er) AES in CBC/CTR/XTS modes

2013-10-04 Thread Nicolas Pitre
On Fri, 4 Oct 2013, Russell King - ARM Linux wrote: > On Fri, Oct 04, 2013 at 08:41:35PM +0200, Ard Biesheuvel wrote: > > On 4 October 2013 20:34, Nicolas Pitre wrote: > > > On Fri, 4 Oct 2013, Will Deacon wrote: > > [...] > > >> > > >> Why do you consider it unsuitable to ship the perl script wi

Re: [PATCH v2 0/3] ARM: NEON based fast(er) AES in CBC/CTR/XTS modes

2013-10-04 Thread Nicolas Pitre
On Fri, 4 Oct 2013, Ard Biesheuvel wrote: > On 4 October 2013 20:34, Nicolas Pitre wrote: > > On Fri, 4 Oct 2013, Will Deacon wrote: > [...] > >> > >> Why do you consider it unsuitable to ship the perl script with the kernel? > >> Perl 5 is already documented as a build dependency in Documentatio

Re: [PATCH v2 0/3] ARM: NEON based fast(er) AES in CBC/CTR/XTS modes

2013-10-04 Thread Russell King - ARM Linux
On Fri, Oct 04, 2013 at 08:41:35PM +0200, Ard Biesheuvel wrote: > On 4 October 2013 20:34, Nicolas Pitre wrote: > > On Fri, 4 Oct 2013, Will Deacon wrote: > [...] > >> > >> Why do you consider it unsuitable to ship the perl script with the kernel? > >> Perl 5 is already documented as a build depen

Re: [PATCH v2 0/3] ARM: NEON based fast(er) AES in CBC/CTR/XTS modes

2013-10-04 Thread Russell King - ARM Linux
On Fri, Oct 04, 2013 at 02:34:01PM -0400, Nicolas Pitre wrote: > Do you have an example of something that does require perl to build the > kernel on ARM? I was under the impression that people try to avoid it > as much as possible in general. > > I'm personally sitting on the fence between effe

Re: [PATCH v2 0/3] ARM: NEON based fast(er) AES in CBC/CTR/XTS modes

2013-10-04 Thread Ard Biesheuvel
On 4 October 2013 20:34, Nicolas Pitre wrote: > On Fri, 4 Oct 2013, Will Deacon wrote: [...] >> >> Why do you consider it unsuitable to ship the perl script with the kernel? >> Perl 5 is already documented as a build dependency in Documentation/Changes > > Do you have an example of something that

Re: [PATCH v2 0/3] ARM: NEON based fast(er) AES in CBC/CTR/XTS modes

2013-10-04 Thread Nicolas Pitre
On Fri, 4 Oct 2013, Russell King - ARM Linux wrote: > Also, remember that the GPL says: > > "The source code for a work means the preferred form of the work for > making modifications to it." > > So here's the question: is the assembly code the perferred form to make > modifications? From what

Re: [PATCH v2 0/3] ARM: NEON based fast(er) AES in CBC/CTR/XTS modes

2013-10-04 Thread Nicolas Pitre
On Fri, 4 Oct 2013, Will Deacon wrote: > Hi Ard, > > On Thu, Oct 03, 2013 at 10:59:23PM +0100, Ard Biesheuvel wrote: > > Note to reviewers: > > Reviewing the file aesbs-core.S may be a bit overwhelming, so if there are > > any > > questions or concerns, please refer the file bsaes-armv7.pl which

Re: [PATCH v2 0/3] ARM: NEON based fast(er) AES in CBC/CTR/XTS modes

2013-10-04 Thread Russell King - ARM Linux
On Fri, Oct 04, 2013 at 08:04:50PM +0200, Ard Biesheuvel wrote: > First of all, please note that the whole point of working so closely > with the OpenSSL maintainer on this is that the version I am > presenting here is the verbatim output of the Perl script that lives > in the OpenSSL tree. So just

Re: [PATCH v2 0/3] ARM: NEON based fast(er) AES in CBC/CTR/XTS modes

2013-10-04 Thread Ard Biesheuvel
On 4 October 2013 19:48, Will Deacon wrote: > On Thu, Oct 03, 2013 at 10:59:23PM +0100, Ard Biesheuvel wrote: >> Note to reviewers: >> Reviewing the file aesbs-core.S may be a bit overwhelming, so if there are >> any >> questions or concerns, please refer the file bsaes-armv7.pl which can be >>

Re: [PATCH v2 0/3] ARM: NEON based fast(er) AES in CBC/CTR/XTS modes

2013-10-04 Thread Will Deacon
Hi Ard, On Thu, Oct 03, 2013 at 10:59:23PM +0100, Ard Biesheuvel wrote: > Note to reviewers: > Reviewing the file aesbs-core.S may be a bit overwhelming, so if there are any > questions or concerns, please refer the file bsaes-armv7.pl which can be found > at the link below. This is the original P

[PATCH v2 0/3] ARM: NEON based fast(er) AES in CBC/CTR/XTS modes

2013-10-03 Thread Ard Biesheuvel
This is v2 of a series implementing a faster and more secure AES implementation based on bit slicing using NEON instructions. Changes since v1: - implemented a suggestion by Jussi Kivilinna which substantially improves decryption performance, decryption speedup is now 25% on Cortex-A15 (up from