Re: [PATCH v2] padata: validate cpumask without removed CPU during offline

2019-08-22 Thread Daniel Jordan
On 8/22/19 6:10 PM, Daniel Jordan wrote: > On 8/21/19 11:50 PM, Herbert Xu wrote: >> On Fri, Aug 09, 2019 at 05:06:03PM -0400, Daniel Jordan wrote: >>> diff --git a/kernel/padata.c b/kernel/padata.c >>> index d056276a96ce..01460ea1d160 100644 >>> --- a/kernel/padata.c >>> +++ b/kernel/padata.c >

Re: [PATCH v2] padata: validate cpumask without removed CPU during offline

2019-08-22 Thread Daniel Jordan
On 8/21/19 11:50 PM, Herbert Xu wrote: On Fri, Aug 09, 2019 at 05:06:03PM -0400, Daniel Jordan wrote: diff --git a/kernel/padata.c b/kernel/padata.c index d056276a96ce..01460ea1d160 100644 --- a/kernel/padata.c +++ b/kernel/padata.c @@ -702,10 +702,7 @@ static int __padata_remove_cpu(struct pada

Re: [PATCH v2] padata: validate cpumask without removed CPU during offline

2019-08-21 Thread Herbert Xu
On Fri, Aug 09, 2019 at 05:06:03PM -0400, Daniel Jordan wrote: > > diff --git a/kernel/padata.c b/kernel/padata.c > index d056276a96ce..01460ea1d160 100644 > --- a/kernel/padata.c > +++ b/kernel/padata.c > @@ -702,10 +702,7 @@ static int __padata_remove_cpu(struct padata_instance > *pinst, int cpu

[PATCH v2] padata: validate cpumask without removed CPU during offline

2019-08-09 Thread Daniel Jordan
Configuring an instance's parallel mask without any online CPUs... echo 2 > /sys/kernel/pcrypt/pencrypt/parallel_cpumask echo 0 > /sys/devices/system/cpu/cpu1/online ...crashes like this: divide error: [#1] SMP PTI CPU: 4 PID: 281 Comm: modprobe Not tainted 5.2.0-padata-base+ #25