Re: [PATCH v2] crypto: reduce minimum alignment of on-stack structures

2021-01-13 Thread Ard Biesheuvel
On Wed, 13 Jan 2021 at 07:27, Herbert Xu wrote: > > On Fri, Jan 08, 2021 at 11:49:32PM +0100, Ard Biesheuvel wrote: > > > > The assumption is that ARCH_SLAB_MINALIGN should be sufficient for any > > POD type, But I guess that in order to be fully correct, the actual > > alignment of the struct typ

Re: [PATCH v2] crypto: reduce minimum alignment of on-stack structures

2021-01-12 Thread Herbert Xu
On Fri, Jan 08, 2021 at 11:49:32PM +0100, Ard Biesheuvel wrote: > > The assumption is that ARCH_SLAB_MINALIGN should be sufficient for any > POD type, But I guess that in order to be fully correct, the actual > alignment of the struct type should be ARCH_SLAB_MINALIGN, and __ctx > should just be pa

Re: [PATCH v2] crypto: reduce minimum alignment of on-stack structures

2021-01-08 Thread Ard Biesheuvel
On Fri, 8 Jan 2021 at 22:16, Eric Biggers wrote: > > On Fri, Jan 08, 2021 at 06:17:06PM +0100, Ard Biesheuvel wrote: > > diff --git a/include/crypto/skcipher.h b/include/crypto/skcipher.h > > index 6a733b171a5d..aa133dc3bf39 100644 > > --- a/include/crypto/skcipher.h > > +++ b/include/crypto/skcip

Re: [PATCH v2] crypto: reduce minimum alignment of on-stack structures

2021-01-08 Thread Eric Biggers
On Fri, Jan 08, 2021 at 06:17:06PM +0100, Ard Biesheuvel wrote: > diff --git a/include/crypto/skcipher.h b/include/crypto/skcipher.h > index 6a733b171a5d..aa133dc3bf39 100644 > --- a/include/crypto/skcipher.h > +++ b/include/crypto/skcipher.h > @@ -128,7 +128,7 @@ struct skcipher_alg { >

[PATCH v2] crypto: reduce minimum alignment of on-stack structures

2021-01-08 Thread Ard Biesheuvel
Unlike many other structure types defined in the crypto API, the 'shash_desc' structure is permitted to live on the stack, which implies its contents may not be accessed by DMA masters. (This is due to the fact that the stack may be located in the vmalloc area, which requires a different virtual-to