Re: [PATCH v2] crypto: add blake2b generic implementation

2019-10-10 Thread David Sterba
Hi, On Wed, Oct 09, 2019 at 03:47:09PM +0200, Ard Biesheuvel wrote: > I have a couple more comments - apologies for not spotting these the > first time around. No problem, there was a lot of churn since v1. > > +enum { > > + BLAKE2_DUMMY_2 = 1 / (sizeof(struct blake2b_param) == > > BLAKE2

Re: [PATCH v2] crypto: add blake2b generic implementation

2019-10-09 Thread Ard Biesheuvel
Hi David, I have a couple more comments - apologies for not spotting these the first time around. On Fri, 4 Oct 2019 at 12:24, David Sterba wrote: > > The patch brings support of several BLAKE2 variants (2b with various > digest lengths). The in-tree user will be btrfs (for checksumming), > we'r

[PATCH v2] crypto: add blake2b generic implementation

2019-10-04 Thread David Sterba
The patch brings support of several BLAKE2 variants (2b with various digest lengths). The in-tree user will be btrfs (for checksumming), we're going to use the BLAKE2b-256 variant. The code is reference implementation taken from the official sources and modified only in terms of kernel coding styl