Re: [PATCH net-next v5 09/20] zinc: Poly1305 ARM and ARM64 implementations

2018-09-18 Thread Jason A. Donenfeld
Hi Eric, On Wed, Sep 19, 2018 at 12:55 AM Eric Biggers wrote: > This will compute the wrong digest if called with simd_context=HAVE_FULL_SIMD > and then later with simd_context=HAVE_NO_SIMD, since poly1305_blocks_neon() > converts the accumulator from base 32 to base 26, whereas > poly1305_block

Re: [PATCH net-next v5 09/20] zinc: Poly1305 ARM and ARM64 implementations

2018-09-18 Thread Eric Biggers
On Tue, Sep 18, 2018 at 06:16:35PM +0200, Jason A. Donenfeld wrote: > diff --git a/lib/zinc/poly1305/poly1305-arm-glue.h > b/lib/zinc/poly1305/poly1305-arm-glue.h > new file mode 100644 > index ..dd3fa5a38c62 > --- /dev/null > +++ b/lib/zinc/poly1305/poly1305-arm-glue.h > @@ -0,0 +1,65

[PATCH net-next v5 09/20] zinc: Poly1305 ARM and ARM64 implementations

2018-09-18 Thread Jason A. Donenfeld
These NEON and non-NEON implementations come from Andy Polyakov's implementation. They are exactly the same as Andy Polyakov's original, with the following exceptions: - Entries and exits use the proper kernel convention macro. - CPU feature checking is done in C by the glue code, so that has been