Hi Ard,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Ard-Biesheuvel/net-fastopen-follow-up-tweaks-for-SipHash-switch/20190621-060434
config: i386-randconfig-x009-201924 (attached as .config)
compil
On Wed, 19 Jun 2019 at 23:42, David Miller wrote:
>
> From: Ard Biesheuvel
> Date: Wed, 19 Jun 2019 08:55:10 +0200
>
> > + ctx->key[0] = (siphash_key_t){
> > + get_unaligned_le64(primary_key),
> > + get_unaligned_le64(primary_key + 8)
> > + };
>
> Please just use n
From: Ard Biesheuvel
Date: Wed, 19 Jun 2019 08:55:10 +0200
> + ctx->key[0] = (siphash_key_t){
> + get_unaligned_le64(primary_key),
> + get_unaligned_le64(primary_key + 8)
> + };
Please just use normal assignment(s), because not only does this warn
it looks not so
On Wed, Jun 19, 2019 at 08:55:10AM +0200, Ard Biesheuvel wrote:
> int tcp_fastopen_reset_cipher(struct net *net, struct sock *sk,
> - void *primary_key, void *backup_key,
> - unsigned int len)
> + void *primary_key, void
Some changes to the TCP fastopen code to make it more robust
against future changes in the choice of key/cookie size, etc.
- Instead of keeping the SipHash key in an untyped u8[] buffer
and casting it to the right type upon use, use the correct
type directly. This ensures that the key will app
